fix(android): use rational format for GPS double tags on write#28
Merged
fix(android): use rational format for GPS double tags on write#28
Conversation
ExifInterface expects GPS rational values in numerator/denominator format. Writing plain decimal strings caused GPS doubles like GPSDOP, GPSImgDirection, GPSSpeed, etc. to silently fail to persist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GPS double tags (GPSDOP, GPSImgDirection, GPSSpeed, GPSTrack, GPSDestBearing, etc.) were not persisted on Android. ExifInterface expects GPS rational values in
numerator/denominatorformat, but we were writing plain decimal strings which were silently dropped onsaveAttributes().Fixes #29
Type of Change
Test Plan
Exify.write(), thenExify.read()— values now persistChecklist