-
Notifications
You must be signed in to change notification settings - Fork 29
update Route53 docs to include ELB and s3-websites integration #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying localstack-docs with
|
| Latest commit: |
50a3738
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6af60216.localstack-docs.pages.dev |
| Branch Preview URL: | https://harshmishra-doc-41.localstack-docs.pages.dev |
remotesynth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment on maybe reconsidering how we structure this to eliminate the need for H4 headings but otherwise looks good.
|
|
||
| You can route traffic from a Route53 domain to an S3 bucket configured for static website hosting using alias records. This is useful when you want to serve a static website with a custom domain name. | ||
|
|
||
| #### Create an S3 bucket with website hosting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really an issue with your doc per se, but we may want to fix styling of H4 elements, because they are currently the same as H3. However, maybe there is a way to restructure this doc so that it only goes to H3? The reason is that H4 elements do not appear in the right hand page nav.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a look at this, the only way he can restructure this doc is if he removed this h2 section:
## Routing traffic to AWS resources
LocalStack Route53 supports routing traffic to various AWS resources using alias records. This allows you to point your domain names directly to AWS services without managing IP addresses.
Then, he could turn both Routing to S3 static websites and Routing to Elastic Load Balancers into h2.
I am also ok with this doc as is, I do not consider the h4 styling problem a blocker for this content. (We could log a ticket to address the h4 styling issue.) But I also get Brian's point, there's always the argument about whether content can be improved/rewritten so that it's not necessary to go 4 levels. 😸
|
@giograno can we please get your review on this one? :D @HarshCasper there's just one pending comment on this one :) |
Fixes DOC-41