Closed
Conversation
Merge remote-tracking branch 'upstream/develop' into kripke_comm_cali
Merge branch 'develop' of https://github.com/LLNL/benchpark into kripke_comm_cali
rfhaque
reviewed
Aug 7, 2024
| "cce": "cray", | ||
| "gcc": "gnu", | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| variant("caliper", default=False, description="Build Caliper support") | |
| def get_make_config_options(self, spec, prefix): | |
| def yes_no(varstr): | |
| return "YES" if varstr in self.spec else "NO" | |
| options = super(Mfem, self).get_make_config_options(spec, prefix) | |
| caliper_opt = ["MFEM_USE_CALIPER=%s" % yes_no("+caliper"), ] | |
| return options + caliper_opt |
…into laghos_comm_cali
c23f9c9 to
f17c109
Compare
f17c109 to
20e479f
Compare
…into laghos_comm_cali changes to configs
rfhaque
reviewed
Aug 17, 2024
| cflags: -g -O2 | ||
| cxxflags: -g -O2 -std=c++17 | ||
| fflags: -g -O2 -hnopattern | ||
| ldflags: {"-ldl"} |
Collaborator
There was a problem hiding this comment.
@pearce8 @gracenansamba Had to add ldflags to get laghos running on tioga. The code runs on ruby, lassen and tioga in the mpi mode
Merge branch 'develop' into laghos_comm_cali
Collaborator
|
@gracenansamba @dyokelson Has this been re-done using the dynamic system+experiment? Should we close this PR? Which PR replaces it? |
Collaborator
Author
|
yes, Laghos has been redone and can eb replaced with |
Collaborator
|
Superseded by #604. |
This was referenced Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Here is the Laghos branch plus the changes I made.
I made changes in repo/mfem, and experiments/laghos/mpi/ramble.yaml
I have attached a link to mfem: https://github.com/gracenansamba/mfem.git
Dependencies: FIXME:Add a list of any dependencies.
Fixes issue(s): FIXME:Add list of relevant issues.
Type of Change
Checklist:
If adding/modifying a system:
system.pyfile.github/workflowsIf adding/modifying a benchpark:
application.pyand (maybe)package.pyunder a new directoryfor this benchmark
section
If adding/modifying a experiment:
experiment.pyunder existing directory for specific benchmarkIf adding/modifying core functionality:
.github/workflowsand.gitlab/ciunit tests (if needed)