Skip to content

Add has_user_timestamp to TrackInfo & AddTrackRequest messages#1428

Open
chenosaurus wants to merge 2 commits intomainfrom
dc/user_timestamp
Open

Add has_user_timestamp to TrackInfo & AddTrackRequest messages#1428
chenosaurus wants to merge 2 commits intomainfrom
dc/user_timestamp

Conversation

@chenosaurus
Copy link

@chenosaurus chenosaurus commented Feb 26, 2026

Adding a field to TrackInfo and AddTrackRequest to indicate whether there are custom rtp trailers associated w/ the track.

@changeset-bot
Copy link

changeset-bot bot commented Feb 26, 2026

⚠️ No Changeset found

Latest commit: 4a3e0e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@chenosaurus chenosaurus marked this pull request as ready for review February 27, 2026 22:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds signaling/model surface area to represent RTP trailer-related capabilities on tracks, enabling clients/servers to indicate the presence of custom RTP trailers (e.g., user timestamp) at publish time and in track metadata.

Changes:

  • Add rtp_trailer_features to AddTrackRequest.
  • Add rtp_trailer_features to TrackInfo.
  • Introduce RTPTrailerFeature enum (currently USER_TIMESTAMP) and regenerate Go protobuf outputs.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
protobufs/livekit_rtc.proto Extends AddTrackRequest with rtp_trailer_features.
protobufs/livekit_models.proto Extends TrackInfo with rtp_trailer_features and adds RTPTrailerFeature enum.
livekit/livekit_rtc.pb.go Regenerated Go output for AddTrackRequest new field wiring.
livekit/livekit_models.pb.go Regenerated Go output for TrackInfo new field and new enum.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 174 to +176
repeated AudioTrackFeature audio_features = 17;

repeated RTPTrailerFeature rtp_trailer_features = 18;
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description mention adding a has_user_timestamp boolean, but the change here introduces a new rtp_trailer_features repeated enum field instead. Please align the PR metadata with the actual API change (or add the intended boolean field) so downstream consumers understand what was added.

Copilot uses AI. Check for mistakes.
}

enum RTPTrailerFeature {
USER_TIMESTAMP = 0;
Copy link

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTPTrailerFeature enum values don’t follow the prefixing convention used by other enums in this file (e.g., RR_*, SE_*, TF_*). To stay consistent and avoid cross-language enum value name collisions, consider renaming USER_TIMESTAMP to a prefixed form (e.g., RTPTF_USER_TIMESTAMP or similar).

Suggested change
USER_TIMESTAMP = 0;
RTPTF_USER_TIMESTAMP = 0;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants