Add has_user_timestamp to TrackInfo & AddTrackRequest messages#1428
Add has_user_timestamp to TrackInfo & AddTrackRequest messages#1428chenosaurus wants to merge 2 commits intomainfrom
Conversation
|
There was a problem hiding this comment.
Pull request overview
Adds signaling/model surface area to represent RTP trailer-related capabilities on tracks, enabling clients/servers to indicate the presence of custom RTP trailers (e.g., user timestamp) at publish time and in track metadata.
Changes:
- Add
rtp_trailer_featurestoAddTrackRequest. - Add
rtp_trailer_featurestoTrackInfo. - Introduce
RTPTrailerFeatureenum (currentlyUSER_TIMESTAMP) and regenerate Go protobuf outputs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| protobufs/livekit_rtc.proto | Extends AddTrackRequest with rtp_trailer_features. |
| protobufs/livekit_models.proto | Extends TrackInfo with rtp_trailer_features and adds RTPTrailerFeature enum. |
| livekit/livekit_rtc.pb.go | Regenerated Go output for AddTrackRequest new field wiring. |
| livekit/livekit_models.pb.go | Regenerated Go output for TrackInfo new field and new enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| repeated AudioTrackFeature audio_features = 17; | ||
|
|
||
| repeated RTPTrailerFeature rtp_trailer_features = 18; |
There was a problem hiding this comment.
PR title/description mention adding a has_user_timestamp boolean, but the change here introduces a new rtp_trailer_features repeated enum field instead. Please align the PR metadata with the actual API change (or add the intended boolean field) so downstream consumers understand what was added.
| } | ||
|
|
||
| enum RTPTrailerFeature { | ||
| USER_TIMESTAMP = 0; |
There was a problem hiding this comment.
RTPTrailerFeature enum values don’t follow the prefixing convention used by other enums in this file (e.g., RR_*, SE_*, TF_*). To stay consistent and avoid cross-language enum value name collisions, consider renaming USER_TIMESTAMP to a prefixed form (e.g., RTPTF_USER_TIMESTAMP or similar).
| USER_TIMESTAMP = 0; | |
| RTPTF_USER_TIMESTAMP = 0; |
Adding a field to TrackInfo and AddTrackRequest to indicate whether there are custom rtp trailers associated w/ the track.