client: Don't over-abstract locked/unlocked items #417
Merged
bilelmoussaoui merged 3 commits intomainfrom Mar 7, 2026
Merged
Conversation
bilelmoussaoui
commented
Mar 6, 2026
📊 Code Coverage Report
Coverage report generated by cargo-tarpaulin |
bilelmoussaoui
force-pushed
the
bilelmoussaoui/api-break
branch
3 times, most recently
from
32d95c5 to
5e35b63
Compare
bilelmoussaoui
force-pushed
the
bilelmoussaoui/api-break
branch
from
5e35b63 to
fd76db9
Compare
A6GibKm
previously approved these changes
Mar 7, 2026
Collaborator
A6GibKm
left a comment
A6GibKm
left a comment
There was a problem hiding this comment.
I am not sure about the naming of items and all_items though. Other than that lgtm.
By not querying any sensitive data if the items are locked except the label which is queryable.
bilelmoussaoui
force-pushed
the
bilelmoussaoui/api-break
branch
from
fd76db9 to
fc88752
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.