Conversation
|
@copilot - is there a test for where the same trigger is used on 2 different statemachines and one or both of them aren't using all of the triggers? Remind me why we were reflecting over all triggers in the first place? |
Added in commit Test for two machines sharing a trigger, each using only a subset: Why were we reflecting? Docs added:
|
|
@copilot - please rebase on main and resolve conflicts |
I'm not able to perform a rebase — my environment doesn't allow force-push, which a rebase would require. You'll need to do one of the following from your local machine: git fetch origin
git checkout copilot/make-libraries-aot-and-trimmed
git rebase origin/main
# resolve any conflicts, then:
git push --force-with-lease origin copilot/make-libraries-aot-and-trimmedOr alternatively, merge main into the branch: git fetch origin
git checkout copilot/make-libraries-aot-and-trimmed
git merge origin/main
git push origin copilot/make-libraries-aot-and-trimmedOnce the branch is up to date I can continue working on it. |
Co-authored-by: leeoades <2321091+leeoades@users.noreply.github.com>
…d trigger type registry Co-authored-by: leeoades <2321091+leeoades@users.noreply.github.com>
…ore.Generator added to samples Co-authored-by: leeoades <2321091+leeoades@users.noreply.github.com>
Co-authored-by: leeoades <2321091+leeoades@users.noreply.github.com>
0515181 to
5fc2462
Compare
|
|
||
| <ItemGroup> | ||
| <ProjectReference Include="..\..\..\src\FunctionalStateMachine.Core\FunctionalStateMachine.Core.csproj" /> | ||
| <ProjectReference Include="..\..\..\src\FunctionalStateMachine.Core.Generator\FunctionalStateMachine.Core.Generator.csproj" |
There was a problem hiding this comment.
@copilot - how does someone consuming the package from Nuget do this? Does the consumer need to reference the core package and add the generator package as a reference or can we make referencing the main package sufficient?
There was a problem hiding this comment.
Referencing FunctionalStateMachine.Core from NuGet is sufficient — no separate generator package needed. The generator DLL is bundled inside the Core NuGet package at analyzers/dotnet/cs, which NuGet automatically applies as an analyzer.
The explicit Core.Generator project reference in the sample apps is only necessary because they use project references (not NuGet packages). That's the exact equivalent of what NuGet does automatically for package consumers.
docs/AOT-and-Trim-Compatibility.md
Outdated
| </Project> | ||
| ``` | ||
|
|
||
| Reference the source generator so the trigger registry is populated at startup: |
There was a problem hiding this comment.
@copilot - I don't think we need to mention this in the docs. It's confusing. Everyone will be consuming the nuget package.
There was a problem hiding this comment.
Removed in commit 43ffdf0 — the project-reference snippet and "Trim propagation to analyzer projects" section are both gone. The "Enabling publishing" section now simply states the generator is bundled in the NuGet package and applied automatically.
…rence-specific sections Co-authored-by: leeoades <2321091+leeoades@users.noreply.github.com>
FunctionalStateMachine.Core.Generatoras analyzer reference toStockPurchaserSampleApp.csproj,VendingMachineSampleApp.csproj, andFunctionalStateMachine.Samples.csprojPublishTrimmed=truepropagation tonetstandard2.0builds<PublishTrimmed>true</PublishTrimmed>to both executable sample csproj filesdocs/Target-Framework-Compatibility.mddocs/AOT-and-Trim-Compatibility.md— updated to remove project-reference-specific sections (confusing to NuGet consumers); simplified "Enabling publishing" section to just say the generator is bundled in the NuGet package automaticallydocs/index.mdandREADME.mdwith links to new pages💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.