Channel cards to unstable#5696
Open
MisRob wants to merge 33 commits intolearningequality:unstablefrom
Open
Conversation
Unstable to channel cards branch
KDS has recently started providing visuallyhidden so is not needed.
and related re-organization of files and tests. Also adds more tests to some components.
MisRob
force-pushed
the
channel-cards
branch
from
fb06598 to
bec64b0
Compare
MisRob
force-pushed
the
channel-cards
branch
7 times, most recently
from
e5ef964 to
6588fd0
Compare
shape of loaded cards.
Fix few regressions, refactor approach to configuration footer.
MisRob
force-pushed
the
channel-cards
branch
from
6588fd0 to
5182209
Compare
MisRob
force-pushed
the
channel-cards
branch
3 times, most recently
from
4176428 to
3a07c26
Compare
MisRob
force-pushed
the
channel-cards
branch
from
3a07c26 to
86d267e
Compare
calculations. The feature is not needed in these use-cases.
MisRob
force-pushed
the
channel-cards
branch
2 times, most recently
from
3b2e264 to
cc563d2
Compare
MisRob
force-pushed
the
channel-cards
branch
from
f4dae95 to
18f4f26
Compare
MisRob
force-pushed
the
channel-cards
branch
from
16ab7ae to
82f701b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces Vuetify-based implementation by
KCardon My Channels, Starred Channels, View-only Channels, and Content Library pages. On this opportunity introduces a new architecture of the related pages and resolves problems with understanding & maintaining monolithic and condition-heavyChannelList+ChannelItem.References
Closes #5227
Closes #5524
Closes #5525
Closes #5526
Reviewer guidance
Code review:
Local preview:
pnpm installfirstNotes
Before merging, [TODO REVERT] Temporarily install KDS fork commit needs to be reverted and a newly released KDS version with learningequality/kolibri-design-system#1203 installed.