Use pointer-based pixel storage in memory efficient replay buffer#8
Open
Use pointer-based pixel storage in memory efficient replay buffer#8
Conversation
Author
|
also done with code/chatGPT have not tested. but @ryanvanderstelt wanted to throw this idea out into the datastore... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
self._pixel_buffers) and expose observation pixel entries asint32pointerBoxspaces instead of full images._insert_pixel_frameand_advance_pixel_pointerto write frames into the ring buffer and advance the frame pointer.insert()to write incoming pixel frames into the ring buffer and store pointer indices inobservations/next_observationsinstead of copying images into each transition.sample()to reconstruct stacked observation tensors by resolving pointer histories from the dataset and indexing into the pixel ring buffer (replacing the previoussliding_window_viewover stored images).Testing
python -m py_compile serl_launcher/serl_launcher/data/memory_efficient_replay_buffer.py.int32pointers; the script completed and returned expected shapes and pointer dtype.Codex Task