Skip to content

Remove @meshery/schemas from peerDependencies#1299

Open
saurabhraghuvanshii wants to merge 1 commit intolayer5io:masterfrom
saurabhraghuvanshii:schema
Open

Remove @meshery/schemas from peerDependencies#1299
saurabhraghuvanshii wants to merge 1 commit intolayer5io:masterfrom
saurabhraghuvanshii:schema

Conversation

@saurabhraghuvanshii
Copy link
Member

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: saurabhraghuvanshii <saurabhsraghuvanshi@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this impact dependent projects?

@saurabhraghuvanshii
Copy link
Member Author

This change is backwards compatible and does not break existing dependents.

  • Projects that already depend on @meshery/schemas (e.g. Meshery UI): No change in behavior. When they upgrade to the new sistent version, npm will install @meshery/schemas as a transitive dependency and will dedupe when the version range is satisfied, so they typically keep using the same copy they already have.
  • Projects that do not list @meshery/schemas (e.g. layer5 site): They currently have to add it manually to fix the build. With the new sistent, it is brought in automatically, so their builds work without that extra step.

Dependent projects are not negatively impacted; they either keep working as before or start working without having to add the peer dependency themselves.

@Bhumikagarggg
Copy link

@saurabhraghuvanshii Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants