docs(im): clarify app visibility for user sends#399
docs(im): clarify app visibility for user sends#399OwenYWT wants to merge 2 commits intolarksuite:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe pull request removes option ID identifiers from API responses in field search operations, adds a corresponding test assertion, and updates Lark IM documentation to clarify that app visibility rules apply regardless of user authentication token type. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis docs-only PR clarifies that Confidence Score: 5/5Safe to merge — docs-only change with accurate, well-placed content additions. All changes are documentation. The new statements about app visibility for No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[lark-cli im +messages-send] --> B{--as identity}
B -->|--as bot| C[Uses tenant_access_token]
B -->|--as user| D[Uses user_access_token]
C --> E{App in target chat\nor DM relationship?}
D --> F{App visible\nto target user?}
F -->|No| G[❌ Feishu rejects:\nvisibility / auth error]
F -->|Yes| H{User has required\nim:message scopes?}
H -->|No| I[❌ Permission denied]
H -->|Yes| J[✅ Message sent as end user]
E -->|No| K[❌ Bot not in chat]
E -->|Yes| L[✅ Message sent as bot]
Reviews (1): Last reviewed commit: "docs(im): clarify app visibility for use..." | Re-trigger Greptile |
Addresses #161
Summary
--as userdirect messages still depend on the app being visible to the recipient+messages-sendreferenceTest Plan
Summary by CodeRabbit
Bug Fixes
Documentation