Skip to content

Conversation

@willyguggenheim
Copy link

Summary

  • Update builder image from golang:1.24.6-bullseye to golang:1.24.13-bookworm in kustomize.Dockerfile
  • Bump go directive in kustomize/go.mod and go.work to 1.24.13
  • Bump github.com/cli/cli from v1.2.1 to v1.14.0 in hack/go.mod

Motivation

The published registry.k8s.io/kustomize/kustomize:v5.6.0 image was built with Go 1.22.7, which has 5 HIGH Go stdlib CVEs:

Additionally, hack/go.mod references github.com/cli/cli v1.2.1 which has CVE-2024-52308 (HIGH). The full fix requires cli/cli v2 (Go 1.25+), so this bumps to the latest v1 (v1.14.0) as an interim improvement.

Note: bullseye was changed to bookworm because the ECR mirror does not publish golang:1.24.13-bullseye.

Test plan

  • Docker image builds successfully with --no-cache
  • Trivy image scan: 0 HIGH/CRITICAL (both alpine OS and gobinary targets clean)
  • go mod tidy runs clean for both kustomize/ and hack/

Update the builder image from golang:1.24.6-bullseye to
golang:1.24.13-bookworm and bump the go directive in kustomize/go.mod
and go.work to 1.24.13. This resolves 5 HIGH Go stdlib CVEs in the
published registry.k8s.io/kustomize/kustomize container image:

- CVE-2025-47907 (database/sql race condition)
- CVE-2025-58183 (archive/tar unbounded allocation)
- CVE-2025-61726 (net/url memory exhaustion)
- CVE-2025-61728 (archive/zip excessive CPU)
- CVE-2025-61729 (crypto/x509 DoS)

Also bumps github.com/cli/cli from v1.2.1 to v1.14.0 in hack/go.mod.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: willyguggenheim
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 7, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: willyguggenheim / name: Willy Guggenheim (492de78, bcaa8c9)

@k8s-ci-robot
Copy link
Contributor

Hi @willyguggenheim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 7, 2026
@willyguggenheim
Copy link
Author

Hi @willyguggenheim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

awesome, please when you can, this PR needs:
/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@willyguggenheim: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Hi @willyguggenheim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

awesome, please when you can, this PR needs:
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mattsanta
Copy link

I tried to upgrade to 1.25.6 in #6048

Update all Dockerfiles, source files, and docs that still referenced
golang:1.24.6 to 1.24.13, matching the go.work and go.mod bump.
Switch bullseye to bookworm as 1.24.13-bullseye is not available.
@k8s-ci-robot
Copy link
Contributor

This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@willyguggenheim
Copy link
Author

Just pushed a fix for the CI test failures. The root cause was that all Dockerfiles and hardcoded version strings in the codebase still referenced golang:1.24.6, but go.work now requires go >= 1.24.13 and the e2e tests use GOTOOLCHAIN=local — so they fail with:

go.work requires go >= 1.24.13 (running go 1.24.6; GOTOOLCHAIN=local)

This commit updates all 16 remaining files that still had 1.24.6:

  • 10 Dockerfiles (e2e tests, function examples, kyaml example, site)
  • 3 Go source files (converter.go, command.go, command_test.go)
  • 2 doc files (functions-impl.md, docs.go)

Also switched bullseyebookworm since golang:1.24.13-bullseye doesn't exist on ECR or Docker Hub.

Tested locally — the previously-failing TestFnContainerGenerator, TestFnContainerTransformer, TestFnContainerEnvVars, and cmd/config TestRunE2e all pass now.

@mattsanta saw your comment about #6048 — this PR takes a more conservative approach by staying on the 1.24.x line (1.24.13) rather than jumping to 1.25.x, which should be a smaller/safer change for now. Happy to coordinate if needed.

Does the PR look good now? Would appreciate an /ok-to-test when you get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants