-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Bump Go to 1.24.13 to resolve stdlib CVEs in container image #6061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bump Go to 1.24.13 to resolve stdlib CVEs in container image #6061
Conversation
Update the builder image from golang:1.24.6-bullseye to golang:1.24.13-bookworm and bump the go directive in kustomize/go.mod and go.work to 1.24.13. This resolves 5 HIGH Go stdlib CVEs in the published registry.k8s.io/kustomize/kustomize container image: - CVE-2025-47907 (database/sql race condition) - CVE-2025-58183 (archive/tar unbounded allocation) - CVE-2025-61726 (net/url memory exhaustion) - CVE-2025-61728 (archive/zip excessive CPU) - CVE-2025-61729 (crypto/x509 DoS) Also bumps github.com/cli/cli from v1.2.1 to v1.14.0 in hack/go.mod.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: willyguggenheim The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @willyguggenheim. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
awesome, please when you can, this PR needs: |
|
@willyguggenheim: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I tried to upgrade to 1.25.6 in #6048 |
Update all Dockerfiles, source files, and docs that still referenced golang:1.24.6 to 1.24.13, matching the go.work and go.mod bump. Switch bullseye to bookworm as 1.24.13-bullseye is not available.
|
This PR has multiple commits, and the default merge method is: merge. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Just pushed a fix for the CI test failures. The root cause was that all Dockerfiles and hardcoded version strings in the codebase still referenced This commit updates all 16 remaining files that still had
Also switched Tested locally — the previously-failing @mattsanta saw your comment about #6048 — this PR takes a more conservative approach by staying on the 1.24.x line (1.24.13) rather than jumping to 1.25.x, which should be a smaller/safer change for now. Happy to coordinate if needed. Does the PR look good now? Would appreciate an |
Summary
golang:1.24.6-bullseyetogolang:1.24.13-bookworminkustomize.Dockerfilegodirective inkustomize/go.modandgo.workto 1.24.13github.com/cli/clifrom v1.2.1 to v1.14.0 inhack/go.modMotivation
The published
registry.k8s.io/kustomize/kustomize:v5.6.0image was built with Go 1.22.7, which has 5 HIGH Go stdlib CVEs:Additionally,
hack/go.modreferencesgithub.com/cli/cliv1.2.1 which has CVE-2024-52308 (HIGH). The full fix requires cli/cli v2 (Go 1.25+), so this bumps to the latest v1 (v1.14.0) as an interim improvement.Note:
bullseyewas changed tobookwormbecause the ECR mirror does not publishgolang:1.24.13-bullseye.Test plan
--no-cachego mod tidyruns clean for bothkustomize/andhack/