fix: actually sort layouts by collection order#3526
Merged
Conversation
isTravis
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Pages with more than one pub block, with pubs sorted by collection order, were not actually sorted by collection order.
That's bc the code was somehow assuming (who could it have been 🤔) that
CollectionPub.rankwas a stringified float, when it was ofc a mudder rank like"aa".Using
localeCompareinstead fixed it.Test Plan
Just send it and see if https://oecs.mit.edu/open-encyclopedia-of-cognitive-science is sorted alphabetically now
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
Supporting Docs