Ralph/eternity loop bun rewrite by robertherber · Pull Request #13 · kingstinct/.github

robertherber · 2026-03-04T13:37:06Z

No description provided.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…tion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…ain loop Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot

Pull request overview

This PR introduces a Bun + TypeScript implementation of the “eternity-loop” automation, replacing/modernizing the previous shell-driven approach with typed workflows that integrate Linear, Git, and GitHub.

Changes:

Adds a Bun/TypeScript CLI (scripts/eternity-loop/index.ts) that bootstraps a tmux + git worktree session and runs an infinite workflow loop.
Implements three workflows (review, CI-fix, new-feature) with Linear querying + GitHub PR/CI interactions and Claude runner prompts.
Adds project-level Bun/TS plumbing (package.json, bun.lock, tsconfig.json) and prompt templates under scripts/eternity-loop/eternity-loop-prompts/.

Reviewed changes

Copilot reviewed 25 out of 28 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tsconfig.json	TypeScript config for Bun-based scripts build/typecheck.
package.json	Declares Bun/TS dependencies for the new eternity-loop tool.
bun.lock	Locks dependency graph for the new Bun package.
.gitignore	Ignores `node_modules/`.
scripts/eternity-loop/index.ts	Main loop runner (settings bootstrap, workflow selection, Ralph execution).
scripts/eternity-loop/bootstrap.ts	tmux + worktree bootstrap and cleanup logic.
scripts/eternity-loop/config.ts	Persists/loads loop settings under `.eternity-loop/`.
scripts/eternity-loop/logger.ts	Timestamped logging helpers.
scripts/eternity-loop/prompts.ts	Loads prompt templates and skill guidelines.
scripts/eternity-loop/ai-runner.ts	Claude CLI runner abstraction.
scripts/eternity-loop/git.ts	Git helpers for branch management and metadata.
scripts/eternity-loop/types.ts	Shared types for settings, issues, and workflow context.
scripts/eternity-loop/providers/types.ts	Provider interface + filtering model.
scripts/eternity-loop/providers/linear.ts	Linear provider implementation for issue discovery and transitions.
scripts/eternity-loop/github/client.ts	Octokit client creation + repo owner/name discovery.
scripts/eternity-loop/github/pr.ts	PR lookup/creation/commenting + PR comment harvesting logic.
scripts/eternity-loop/github/ci.ts	CI failure detection + failure detail extraction.
scripts/eternity-loop/ralph.ts	Ralph execution loop, progress archiving, and notifications.
scripts/eternity-loop/workflows/types.ts	Workflow interface definition.
scripts/eternity-loop/workflows/review.ts	Review workflow: detect new human comments, generate PRD, reply summary.
scripts/eternity-loop/workflows/ci-fix.ts	CI-fix workflow: detect failures, generate CI-fix PRD, post progress.
scripts/eternity-loop/workflows/new-feature.ts	New-feature workflow: move Linear issue to in-progress, generate PRD, create PR.
scripts/eternity-loop/eternity-loop-prompts/*	Prompt templates for PRD creation, PR creation, and comment replies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-04T13:43:08Z

scripts/eternity-loop/bootstrap.ts

+  const argsStr = args.join(" ");
+  const envVars = [
+    `ETERNITY_LOOP_INSIDE=1`,
+    `ETERNITY_LOOP_WORKTREE='${worktreePath}'`,
+    `ETERNITY_LOOP_REPO_ROOT='${repoRoot}'`,
+    `LINEAR_API_KEY='${process.env.LINEAR_API_KEY ?? ""}'`,
+  ].join(" ");
+
+  const cmd = `cd '${worktreePath}' && ${envVars} bun '${scriptPath}' ${argsStr}; echo 'Eternity loop exited. Press enter to close.'; read`;


The tmux command embeds LINEAR_API_KEY directly into the shell command string. This leaks the secret via process listings and (depending on tmux config) can persist in scrollback/logs. Pass secrets via the spawned process environment (or tmux set-environment) rather than interpolating them into cmd.

Copilot · 2026-03-04T13:43:09Z

scripts/eternity-loop/bootstrap.ts

+  // Build the command to run inside tmux
+  const argsStr = args.join(" ");
+  const envVars = [
+    `ETERNITY_LOOP_INSIDE=1`,
+    `ETERNITY_LOOP_WORKTREE='${worktreePath}'`,
+    `ETERNITY_LOOP_REPO_ROOT='${repoRoot}'`,
+    `LINEAR_API_KEY='${process.env.LINEAR_API_KEY ?? ""}'`,
+  ].join(" ");
+
+  const cmd = `cd '${worktreePath}' && ${envVars} bun '${scriptPath}' ${argsStr}; echo 'Eternity loop exited. Press enter to close.'; read`;


argsStr = args.join(" ") is inserted into a shell command executed by tmux. This breaks when args contain spaces/shell metacharacters and also allows shell injection from crafted arguments. Prefer passing arguments without going through a shell string (e.g., invoke tmux new-session ... -- bun scriptPath ...args if supported) or robustly shell-escape each arg.

Copilot · 2026-03-04T13:43:10Z

scripts/eternity-loop/bootstrap.ts

+  const repoRoot = (await $`git rev-parse --show-toplevel`.text()).trim();
+  const projectName = repoRoot.split("/").pop() ?? "unknown";
+  const tmuxSession = `eternity-loop-${projectName}`;
+  const worktreePath = join(repoRoot, ".claude/worktrees/eternity-loop");


This worktree path is inside the repo under .claude/worktrees/..., but existing session tooling in this repo places worktrees under $HOME/code/worktrees/<repo-name>/... (see scripts/session-init.sh:50-51). Using a different location can lead to duplicated conventions and accidental repo pollution; consider aligning the location or making it configurable.

Suggested change

const worktreePath = join(repoRoot, ".claude/worktrees/eternity-loop");

const defaultWorktreeRoot = join(repoRoot, ".claude/worktrees");

const externalWorktreeRoot = process.env.HOME

? join(process.env.HOME, "code", "worktrees", projectName)

: defaultWorktreeRoot;

const worktreePath = join(externalWorktreeRoot, "eternity-loop");

Copilot · 2026-03-04T13:43:10Z

scripts/eternity-loop/git.ts

+export async function checkoutBranch(workDir: string, branch: string): Promise<void> {
+  // Try checking out existing branch first, create from remote if available
+  try {
+    await $`git -C ${workDir} checkout ${branch}`.quiet();
+  } catch {
+    try {
+      await $`git -C ${workDir} checkout -b ${branch} origin/${branch}`.quiet();
+    } catch {
+      await $`git -C ${workDir} checkout -b ${branch}`;
+    }
+  }


checkoutBranch never fetches from origin. In a long-running loop, newly created/updated remote branches may not exist in local origin/* refs, causing git checkout -b ... origin/branch to fail or the agent to work on stale commits. Fetch (optionally targeted to the branch) before attempting the checkout, or fetch once per loop iteration.

Copilot · 2026-03-04T13:43:10Z

scripts/eternity-loop/github/ci.ts

+            const { data: logData } = await octokit.actions.downloadJobLogsForWorkflowRun({
+              owner,
+              repo,
+              job_id: failedJob.id,
+            });
+
+            const log = typeof logData === "string" ? logData : String(logData);
+            const lines = log.split("\n");
+
+            if (lines.length > 500) {
+              const first100 = lines.slice(0, 100).join("\n");
+              const last400 = lines.slice(-400).join("\n");
+              parts.push("```");
+              parts.push(first100);
+              parts.push("\n... (truncated) ...\n");
+              parts.push(last400);
+              parts.push("```");
+            } else {
+              parts.push("```");
+              parts.push(log);
+              parts.push("```");


downloadJobLogsForWorkflowRun returns a zipped/binary payload (and often via redirect), not plain text. Converting it with String(logData) and splitting on newlines will usually produce unusable output (e.g., [object ArrayBuffer]) and won’t yield CI logs. Either omit inline logs and include details_url, or download and unzip the logs before parsing, or use an API that returns text output.

Suggested change

const { data: logData } = await octokit.actions.downloadJobLogsForWorkflowRun({

owner,

repo,

job_id: failedJob.id,

});

const log = typeof logData === "string" ? logData : String(logData);

const lines = log.split("\n");

if (lines.length > 500) {

const first100 = lines.slice(0, 100).join("\n");

const last400 = lines.slice(-400).join("\n");

parts.push("```");

parts.push(first100);

parts.push("\n... (truncated) ...\n");

parts.push(last400);

parts.push("```");

} else {

parts.push("```");

parts.push(log);

parts.push("```");

parts.push("Logs are available in GitHub Actions:");

if (check.details_url) {

parts.push(check.details_url);

} else {

parts.push("(No details URL available for this check)");

Copilot · 2026-03-04T13:43:11Z

scripts/eternity-loop/ralph.ts

+    await Bun.$`MESSAGE=${message} ${scriptPath}`.env({
+      ...process.env,
+      DISABLE_PUSHOVER_NOTIFICATIONS: undefined as unknown as string,
+      RALPH_LOOP: undefined as unknown as string,
+      MESSAGE: message,
+    }).quiet();


Using undefined as unknown as string to "unset" env vars is type-unsafe and may not actually remove the variables (it can end up setting them to the literal string "undefined" depending on how Bun handles the env map). Build an env object, delete the keys you want to remove, and pass the cleaned object to .env() instead.

Suggested change

await Bun.$`MESSAGE=${message} ${scriptPath}`.env({

...process.env,

DISABLE_PUSHOVER_NOTIFICATIONS: undefined as unknown as string,

RALPH_LOOP: undefined as unknown as string,

MESSAGE: message,

}).quiet();

const env = {

...process.env,

MESSAGE: message,

};

delete (env as Record<string, string | undefined>).DISABLE_PUSHOVER_NOTIFICATIONS;

delete (env as Record<string, string | undefined>).RALPH_LOOP;

await Bun.$`MESSAGE=${message} ${scriptPath}`.env(env).quiet();

The eternity-loop has been fully rewritten in TypeScript/Bun. The prompts now live at scripts/eternity-loop/eternity-loop-prompts/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

robertherber and others added 18 commits March 4, 2026 13:37

feat: [US-001] - Set up project structure and dependencies

ccc6752

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-002] - Create shared types

931caf0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-003] - Create logger module

bccf8cf

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-004] - Create config module

d2f59fd

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-005] - Create prompts module

b0dd7cf

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-006] - Create git operations module

24f499f

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-007] - Create AI runner interface and Claude CLI implementa…

52ce27d

…tion Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-008] - Create IssueProvider interface and Linear provider

6d709ba

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-009] - Create GitHub client module

643a811

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-010] - Create GitHub PR module

becdcaf

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-011] - Create GitHub PR comments module

eda028c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-012] - Create GitHub CI module

6a0ad2e

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-013] - Create ralph loop runner

1274461

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-014] - Create workflow interface and review workflow

c1fb0b6

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-015] - Create CI fix workflow

2cfc273

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-016] - Create new feature workflow

505d73c

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-017] - Create bootstrap module

070d3d0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

feat: [US-018] - Create main entry point with interactive setup and m…

b0346f0

…ain loop Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings March 4, 2026 13:37

Copilot started reviewing on behalf of robertherber March 4, 2026 13:37 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

robertherber and others added 5 commits March 4, 2026 23:02

make it bin-runnable

c731d23

improvements

94aaace

minor fixes

313e611

chore: remove old bash eternity-loop script and prompts

fc90043

The eternity-loop has been fully rewritten in TypeScript/Bun. The prompts now live at scripts/eternity-loop/eternity-loop-prompts/. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

update ci-fix prompt

dc73274

robertherber merged commit cd4dd61 into main Mar 5, 2026
2 checks passed

robertherber deleted the ralph/eternity-loop-bun-rewrite branch March 5, 2026 13:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ralph/eternity loop bun rewrite#13

Ralph/eternity loop bun rewrite#13
robertherber merged 23 commits intomainfrom
ralph/eternity-loop-bun-rewrite

robertherber commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Copilot AI Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-  const worktreePath = join(repoRoot, ".claude/worktrees/eternity-loop");
+  const defaultWorktreeRoot = join(repoRoot, ".claude/worktrees");
+  const externalWorktreeRoot = process.env.HOME
+    ? join(process.env.HOME, "code", "worktrees", projectName)
+    : defaultWorktreeRoot;
+  const worktreePath = join(externalWorktreeRoot, "eternity-loop");

Conversation

robertherber commented Mar 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants