Fix #3389: 1.18.2 How do I get the {killer_item} to display the actual item name?#3495
Closed
kangobot[bot] wants to merge 1 commit intomasterfrom
Closed
Fix #3389: 1.18.2 How do I get the {killer_item} to display the actual item name?#3495kangobot[bot] wants to merge 1 commit intomasterfrom
kangobot[bot] wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated fix proposed by AI analysis of the linked issue.
Changes
main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/operator/DeathMessage.java: Fix {killer_item_name} stripping real colors from plugin-colored items. The previous CompChatColor.stripColorCodes() strips both § (real) and & (fake) codes. Now only & codes are stripped (anvil injection prevention), while § codes are preserved and converted to MiniMessage for proper chat rendering.main/chatcontrol-bukkit/src/main/java/org/mineacademy/chatcontrol/operator/DeathMessage.java: Remove unused CompChatColor import after switching to regex-based & strippingThis is a draft PR — human review required before merging.