Skip to content

urgent security fix: digest verification #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
junkurihara merged 1 commit into from
Feb 14, 2026
Merged

urgent security fix: digest verification #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions httpsig-hyper/src/hyper_content_digest.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ where
.map_err(|_e| HyperDigestError::HttpBodyError("Failed to get body bytes".to_string()))?;
let digest = derive_digest(&body_bytes, &cd_type);

if matches!(digest, _expected_digest) {
if digest == _expected_digest {
Copy link
Owner

@junkurihara junkurihara Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the next release, I will switch the digest comparison to a constant-time comparison as defense-in-depth, and add regression tests to ensure this class of bug cannot be reintroduced.

let new_body = Full::new(body_bytes).map_err(|never| match never {}).boxed();
let res = Request::from_parts(header, new_body);
Ok(res)
Expand Down Expand Up @@ -192,7 +192,7 @@ where
.map_err(|_e| HyperDigestError::HttpBodyError("Failed to get body bytes".to_string()))?;
let digest = derive_digest(&body_bytes, &cd_type);

if matches!(digest, _expected_digest) {
if digest == _expected_digest {
Copy link
Owner

@junkurihara junkurihara Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

let new_body = Full::new(body_bytes).map_err(|never| match never {}).boxed();
let res = Response::from_parts(header, new_body);
Ok(res)
Expand Down