Add edge case tests for builder and parser#4
Merged
Conversation
…racters, numeric entities, and malformed XML
There was a problem hiding this comment.
Pull request overview
Adds additional edge-case coverage (and supporting parser changes) to improve robustness of the XML parser/builder when encountering numeric entities and malformed inputs.
Changes:
- Extend entity decoding to support numeric character references (
&#...;,&#x...;). - Add a parser guard to avoid stack underflow on extra closing tags.
- Introduce extensive new edge-case tests for
parse()andbuild()(entities, malformed XML, whitespace/CDATA/attributes, large payloads).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
src/parse.ts |
Adds numeric entity decoding and a guard for extra closing tags during parsing. |
src/__tests__/parse.test.ts |
Adds many new parser edge-case tests (entities, malformed XML, whitespace/CDATA, attributes, large payloads). |
src/__tests__/build.test.ts |
Adds builder edge-case tests for escaping, deep nesting, arrays, falsy primitives, and empty structures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ng for malformed XML
paustint
force-pushed
the
feat/numeric-entities
branch
from
25ca680 to
e3c0773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce tests to validate the handling of special characters, numeric entities, and malformed XML in the builder and parser functions. These tests ensure robustness against various edge cases.