Add support for fetching keys from a JWKS endpoint#777
Open
SgtCoDFish wants to merge 1 commit intomasterfrom
Open
Add support for fetching keys from a JWKS endpoint#777SgtCoDFish wants to merge 1 commit intomasterfrom
SgtCoDFish wants to merge 1 commit intomasterfrom
Conversation
SgtCoDFish
force-pushed
the
keyfetch
branch
20 times, most recently
from
49fefca to
0337378
Compare
This requires changing a few function signatures and plumbing some things together. Notably, I don't want to have a second service discovery client and send duplicate calls off, so I shared the service discovery client from the CyberArk client and added caching of responses to the service discovery client. I also had to share credentials for auth. Also removes encrypted-secrets example The machinehub mode is required for key fetching, but doesn't play nicely with one shot mode and the example hangs. Secret encryption is covered in the e2e tests, so just remove the example for simplicity Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This requires changing a few function signatures and plumbing some things together.
Notably, I don't want to have a second service discovery client and send duplicate calls off, so I shared the service discovery client from the CyberArk client and added caching of responses to the service discovery client.
Likewise, I needed to handle auth for the jwks endpoint. I'd rather not have to have a second identity client (we could just have one) but this works for now.
Unfortunately, that means this is much longer than I'd have hoped but most of the changes are pretty simple.