Separate token creation logic from the create method#250
Open
ayys wants to merge 1 commit intojazzband:developfrom
Open
Separate token creation logic from the create method#250ayys wants to merge 1 commit intojazzband:developfrom
ayys wants to merge 1 commit intojazzband:developfrom
Conversation
Separates the logic of creating cryptographic token from the create
method. This way, implementing another way to generate tokens becomes easier.
Any function that returns a dict with the following layout can be
plugged in.
{
"token": <token string>,
"expiry": <digest hash>,
"expiry": <expiry datetime>,
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the logic of creating cryptographic token from the create into generate_token method
This way, implementing another way to generate tokens becomes easier. Any function that returns a dict with the following layout can be plugged in.