Skip to content

feat(segment-view): add swipeGesture property to disable swiping #30948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
brandyscarney wants to merge 5 commits into
base: feature-8.8
Choose a base branch
from
Open

feat(segment-view): add swipeGesture property to disable swiping #30948

brandyscarney wants to merge 5 commits into from

Conversation

@brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Feb 6, 2026 •
edited
Loading

Issue number: resolves #30290

What is the current behavior?

The segment view swipe gesture can only be disabled by adding the disabled property and setting opacity: 1.

What is the new behavior?

  • Adds a new property, swipeGesture, to disable swiping on the segment view
  • Adds an e2e test which verifies the styles blocking the swipe are correctly applied when swipeGesture is false
    • I tried to simulate touch/scroll gestures, but Playwright/browser limitations with scroll-snap make it impossible to reliably test swipe disabling.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.7.17-dev.11770405784.157a3c10

Segment View Preview

@vercel
Copy link

vercel bot commented Feb 6, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-framework Ready Ready Preview, Comment Feb 6, 2026 9:37pm

Request Review

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Feb 6, 2026
@brandyscarney brandyscarney marked this pull request as ready for review February 6, 2026 21:38
@brandyscarney brandyscarney requested a review from a team as a code owner February 6, 2026 21:38
@brandyscarney brandyscarney requested a review from thetaPC February 6, 2026 21:38
ShaneK
ShaneK approved these changes Feb 9, 2026
View reviewed changes
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

thetaPC
thetaPC approved these changes Feb 9, 2026
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaneK ShaneK ShaneK approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees

No one assigned

Labels

package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brandyscarney @ShaneK @thetaPC