feat(wallet): Gracefully handle 422 guardian errors for native clients#2799
Open
JCSanPedro wants to merge 2 commits intomainfrom
Open
feat(wallet): Gracefully handle 422 guardian errors for native clients#2799JCSanPedro wants to merge 2 commits intomainfrom
JCSanPedro wants to merge 2 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit a693f52
☁️ Nx Cloud last updated this comment at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
type(scope): message. For example:feat(passport): my new feature!after thetype(scope), for examplefeat(passport)!: my new breaking featureSummary
Native (Unreal/Unity) SDK clients that use the game bridge cannot display the Guardian confirmation screen, so they have historically received a generic
TRANSACTION_REJECTEDerror whenever a transaction needed user approval — including when the transaction would revert on-chain. This gave developers no way to distinguish a definite revert from a transaction that simply needs user approval.The Guardian API will begin returning a 422 response (instead of
200 confirmationRequired: true) when a simulated transaction will revert, but only for native clients on SDK >= 2.13.0. This SDK change handles that new response:TRANSACTION_REVERTED (-32015)and the simulation revert reason surfaced in the message. Developers can now programmatically distinguish a definite revert from other error conditions.New error code:
RpcErrorCode.TRANSACTION_REVERTED = -32015added to JsonRpcError.ts.