Imagekit video player by aman051197 · Pull Request #1 · imagekit-developer/imagekit-video-player

aman051197 · 2026-01-20T10:39:27Z

No description provided.

Co-authored-by: Abhinav Dhiman <ahnv@users.noreply.github.com>

…uration

…teTextTrack options

…menu bar

…dded github pages configurations.

…ss video player modules

…re effectively

…efinitions for improved maintainability

ahnv · 2026-01-21T11:24:59Z

packages/video-player/javascript/index.ts

+  private ikGlobalSettings_: IKPlayerOptions;
+  private currentSource_: SourceOptions | SourceOptions[] | null = null;
+  private originalCurrentSource_: SourceOptions | SourceOptions[] | null = null;
+  private playlistManger_?: PlaylistManager;


typo: playlistManager

ahnv · 2026-01-21T11:25:19Z

packages/video-player/javascript/index.ts

+    if (!src.recommendations) return;
+
+    const overlay = this.player.getChild('RecommendationsOverlay');
+    console.log('RecommendationsOverlay:', overlay);


remove console log before releasing

ahnv · 2026-01-21T11:25:27Z

packages/video-player/javascript/index.ts

+            // if poster is already prepared, use it directly
+            // @ts-ignore
+            if (currentSource_?.prepared?.poster) {
+              console.log("Using prepared poster src")


remove console log before releasing

ahnv · 2026-01-21T11:25:49Z

packages/video-player/javascript/index.ts

+      try {
+        const res = await fetch(src.chapters.url);
+        if (!res.ok) {
+          this.player.log.warn(`VTT fetch failed with status: (${res.status}); skipping chapters.`);


return statement after this warning is missing

ahnv · 2026-01-21T11:26:33Z

packages/video-player/javascript/index.ts

+                  src.prepared = {}
+                }
+                // @ts-ignore
+                src.prepared.src = prepared[0].src;


always assigns to 0th index

ahnv · 2026-01-21T11:31:54Z

packages/video-player/javascript/modules/playlist/playlist-manager.ts

+    this.unloadPlaylist();
+
+    this.playlist_ = playlist;
+    this.autoAdvance_ = new AutoAdvance(this.player_, this.playNext_);


we should dispose autoadvance, by doing this.autoAdvance_?.fullReset() before creating new one

ahnv · 2026-01-21T11:32:35Z

packages/video-player/javascript/modules/playlist/playlist-manager.ts

+    if (!currentTime || !duration || !isFinite(duration) || !isFinite(currentTime)) {
+      return;
+    }


what happens if currentTime or duration === 0? duration i understand won't cause issues but currentTime can be 0

ahnv · 2026-01-21T11:33:34Z

packages/video-player/javascript/modules/playlist/playlist-manager.ts

+  private setupPresentUpcoming_() {
+    // Always remove the old component first
+    this.presentUpcomingComponent_?.dispose();
+    this.player_.off('timeupdate', this.handleTimeUpdateForUpcoming_);
+
+    if (this.presentUpcomingThreshold_ === null) {
+      // If the feature is disabled, we're done.
+      return;
+    }
+
+    // Create and add the new component to the player
+    this.presentUpcomingComponent_ = this.player_.addChild('PresentUpcoming', this.playerOptions_) as PresentUpcoming;
+
+    this.presentUpcomingComponent_.on('dismiss', this.handleUpcomingDismiss_);
+
+
+    // Listen for time updates to know when to show it
+    this.player_.on('timeupdate', this.handleTimeUpdateForUpcoming_);
+
+    // Also hide it immediately when a new source starts loading
+    this.player_.on('loadstart', () => {
+      this.presentUpcomingComponent_?.hide();
+      // --- CHANGE: MOVED TO HERE ---
+      // This is the correct place to reset the dismissed state for the upcoming video.
+      this.isUpcomingDismissed_ = false;
+    });
+  }


we should have a function for loadstart body and remove the listener like we do for timeupdate

ahnv · 2026-01-21T11:34:13Z

packages/video-player/javascript/modules/shoppable/shoppable.css

+  top: 50%;
+  left: 50%;
+  transform: translate(-50%, -50%);
+  animation: pulse 2s infinite;


where is this animation defined?

ahnv · 2026-01-21T11:34:56Z

packages/video-player/javascript/modules/shoppable/shoppable.css

+.vjs-shoppable-toggle .icon-open {
+  opacity: 1;
+}
+
+.vjs-shoppable-toggle .icon-close {
+  opacity: 1;
+}


open and close both have opacity 1

ahnv · 2026-01-22T05:17:46Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 785dd49517

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-01-22T05:20:11Z

packages/video-player/javascript/index.ts

+            inputs.forEach((src) => {
+              if (typeof src === 'object' && src !== null && !this.hasPreparedSrc(src)) {
+                ensurePrepared(src as AugmentedSourceOptions).src = prepared[0].src;
+              }


Preserve per-source prepared URLs

When multiple sources are passed (e.g., different qualities or HLS+MP4), this loop writes prepared[0].src into every input’s prepared.src. If the caller reuses the same source objects later, hasPreparedSrc will short‑circuit prepareSource and all entries will resolve to the first URL, breaking source selection and potentially serving the wrong file. Each input should get its corresponding prepared[i].src so cached preparation stays aligned with the source array.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-01-22T05:20:11Z

packages/video-player/javascript/index.ts

+        .finally(() => {
+          // hide the spinner and show the big play button
+          bigPlay && bigPlay.show();
+          this.player.removeClass('vjs-waiting');
+          spinner?.el()?.setAttribute('aria-hidden', 'true');


Guard spinner teardown against stale src() calls

The finally block always hides the spinner and shows the big play button, even if a newer src() call is still in flight. If a user switches sources quickly or an earlier request resolves after a later one starts, the older promise will flip the UI to “not loading” while the latest source is still preparing, causing incorrect loading state. Consider checking myCallId === this.srcCallVersion before toggling UI state here.

Useful? React with 👍 / 👎.

…tTrack(), improved subtitle generation logic, fixed code to display on github pages

…yles

…nd UI improvements

…eaner presentation

… enhance Vue support, and improve keyboard shortcuts functionality

… dimensions

… logic with content change detection

aman-imagekit and others added 30 commits June 9, 2025 16:23

feat: WIP video-player

1286357

feat: WIP angular wrapper, changed package manager to pnpm from yarn

d1ecd70

feat: playlist CSS fixed

ea0dbb6

fix: CSS issues fixed chapters, thumbnails, subtitles highlighting

8e820bc

feat: WIP shoppable

f6d7ad7

fix: CSS issues in post play shoppable overlay

32a8a9d

WIP

9a8caca

Co-authored-by: Abhinav Dhiman <ahnv@users.noreply.github.com>

build: migrate from pnpm to yarn and restructure Angular build config…

60cf66b

…uration

docs: add development setup instructions to README

68824cc

WIP: vue wrapper working + layout issues fixed when fluid is present

6184e8d

feat: added floatingWhenNotVisible, added logic for translate in Remo…

5105426

…teTextTrack options

feat: added present upcoming

f79c117

feat: added context menu

1914bdf

feat: added grab carousal, cross button

0579c8a

fix: CSS fixes for recommendation overlay, next up widget, shoppable …

4b9a627

…menu bar

feat: WIP added pages for different features in javascript example, a…

408d1e4

…dded github pages configurations.

chore: trigger action on pushing changes in dev branch

3e02c6e

feat: enable corepack in github workflow

295306b

temp: skip building angular

eab6297

feat: added logic to skip preparing urls once prepared in playlist

b052e59

fix: links fixed in javascript example

de5d51c

fix: tyescript error fix

13b5429

fix: back to examples fix, styles on index not loading fix

d8b2c1d

feat: refactored shoppable

989c520

feat: added playlist next/previous controls

6c92ef3

chore: playlist, control bar feedback addressed

8317552

feedback 2

b8ad81a

fix: abs path

672a125

fix: icon style fix

6de8a35

fix: waitForVideo logic fix

f064331

aman-imagekit added 5 commits January 19, 2026 12:18

refactor: update subtitle handling and improve caption generation logic

7dec285

feat: integrate CleanupRegistry for improved resource management acro…

2e3d7c6

…ss video player modules

feat: enhance context menu cleanup logic to manage event listeners mo…

a4e3e1f

…re effectively

feat: update video source URLs for player examples to new staging links

15f4ef4

refactor: streamline video player module structure and enhance type d…

785dd49

…efinitions for improved maintainability

aman051197 temporarily deployed to github-pages January 22, 2026 05:03 — with GitHub Actions Inactive

ahnv requested changes Jan 22, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Jan 22, 2026

View reviewed changes

aman-imagekit added 5 commits January 28, 2026 09:18

chore: remove Angular example files and clean up project structure

a2d2876

updated text track options, removed overriding of player.addRemoteTex…

437dc7f

…tTrack(), improved subtitle generation logic, fixed code to display on github pages

chore: update Vite configuration and import paths for video player st…

1dddd4e

…yles

feat: enhance chapters functionality with new configuration options a…

1714fb6

…nd UI improvements

fix: remove subtitles from video info objects in App component for cl…

79c8b94

…eaner presentation

aman051197 had a problem deploying to github-pages February 2, 2026 05:55 — with GitHub Actions Failure

chore: update package.json to include all examples in workspaces

2a46d31

aman051197 had a problem deploying to github-pages February 2, 2026 06:29 — with GitHub Actions Failure

temp: workspace configuration updated

987bbee

aman051197 temporarily deployed to github-pages February 2, 2026 06:35 — with GitHub Actions Inactive

aman-imagekit added 2 commits February 3, 2026 01:29

feat: add new assets build step and include info-circle icon in styles

80cb2de

refactor: update video player package to remove Angular dependencies,…

bf9a088

… enhance Vue support, and improve keyboard shortcuts functionality

aman051197 temporarily deployed to github-pages February 10, 2026 12:23 — with GitHub Actions Inactive

aman051197 temporarily deployed to github-pages February 10, 2026 22:20 — with GitHub Actions Inactive

style: enhance playlist UI with flexbox layout and improved thumbnail…

1f6a09b

… dimensions

aman051197 force-pushed the dev branch from 05c7180 to 1f6a09b Compare February 10, 2026 22:21

aman051197 temporarily deployed to github-pages February 10, 2026 22:21 — with GitHub Actions Inactive

refactor: simplify playlist menu item retrieval and enhance UI update…

a815336

… logic with content change detection

aman051197 temporarily deployed to github-pages February 10, 2026 23:52 — with GitHub Actions Inactive

chore: updated README.md

4d57563

aman051197 deployed to github-pages February 12, 2026 10:22 — with GitHub Actions View deployment

Conversation

aman051197 commented Jan 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ahnv commented Jan 22, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Jan 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments