Skip to content

fix UCT HLLD when using DIMENSIONS<COMPONENTS #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
glesur wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix UCT HLLD when using DIMENSIONS<COMPONENTS #363

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3072d
fix UCT HLLD when using DIMENSIONS<COMPONENTS
glesur Jan 30, 2026
250c641
fix unused variable warning with nvcc
glesur Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/fluid/RiemannSolver/MHDsolvers/storeFlux.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ KOKKOS_FORCEINLINE_FUNCTION void K_StoreHLLD( const int i, const int j, const in
const IdefixArray3D<real> &aR,
const IdefixArray3D<real> &dL,
const IdefixArray3D<real> &dR) {
EXPAND( const int Xn = DIR+MX1; ,
const int Xt = (DIR == IDIR ? MX2 : MX1); ,
const int Xb = (DIR == KDIR ? MX2 : MX3); )
EXPAND( const int Xn = DIR+MX1; ,
const int Xt = (DIR == IDIR ? MX2 : MX1); ,
[[maybe_unused]] const int Xb = (DIR == KDIR ? MX2 : MX3); )
// Compute magnetic pressure
[[maybe_unused]] real ptR, ptL;

Expand Down Expand Up @@ -201,7 +201,7 @@ KOKKOS_FORCEINLINE_FUNCTION void K_StoreHLLD( const int i, const int j, const in
}

#if COMPONENTS > 1
EXPAND( Et(k,j,i) = -st*(ar*vL[Xt] - al*vR[Xt])*scrh; ,
D_EXPAND( Et(k,j,i) = -st*(ar*vL[Xt] - al*vR[Xt])*scrh; ,
,
Eb(k,j,i) = -sb*(ar*vL[Xb] - al*vR[Xb])*scrh; );
#endif
Expand Down
Loading