Skip to content

Add HSE_MHZ option to OMNIBUSF4V3_ICM target#11331

Open
danilo19992 wants to merge 1 commit intoiNavFlight:masterfrom
danilo19992:patch-4
Open

Add HSE_MHZ option to OMNIBUSF4V3_ICM target#11331
danilo19992 wants to merge 1 commit intoiNavFlight:masterfrom
danilo19992:patch-4

Conversation

@danilo19992
Copy link

controladora f4 s3v plus

@github-actions
Copy link

Branch Targeting Suggestion

You've targeted the master branch with this PR. Please consider if a version branch might be more appropriate:

  • maintenance-9.x - If your change is backward-compatible and won't create compatibility issues between INAV firmware and Configurator 9.x versions. This will allow your PR to be included in the next 9.x release.

  • maintenance-10.x - If your change introduces compatibility requirements between firmware and configurator that would break 9.x compatibility. This is for PRs which will be included in INAV 10.x

If master is the correct target for this change, no action is needed.


This is an automated suggestion to help route contributions to the appropriate branch.

@qodo-code-review
Copy link
Contributor

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Review Summary by Qodo

Add HSE_MHZ 8 MHz configuration to OMNIBUSF4V3_ICM

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Adds HSE_MHZ configuration option to OMNIBUSF4V3_ICM target
• Sets external oscillator frequency to 8 MHz
• Maintains SKIP_RELEASES flag for the target
Diagram
flowchart LR
  A["OMNIBUSF4V3_ICM target"] -- "Add HSE_MHZ 8 MHz" --> B["Enhanced target configuration"]
Loading

Grey Divider

File Changes

1. src/main/target/OMNIBUSF4/CMakeLists.txt ⚙️ Configuration changes +1/-0

Add HSE_MHZ 8 MHz to OMNIBUSF4V3_ICM target

• Adds new target configuration line for OMNIBUSF4V3_ICM
• Specifies HSE_MHZ parameter set to 8 MHz
• Preserves SKIP_RELEASES flag in the configuration

src/main/target/OMNIBUSF4/CMakeLists.txt


Grey Divider

Qodo Logo

@qodo-code-review
Copy link
Contributor

ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider


Action required

1. Duplicate CMake target 🐞 Bug ✓ Correctness
Description
OMNIBUSF4V3_ICM is defined twice, which will attempt to create the same CMake executable target
(OMNIBUSF4V3_ICM.elf) twice and fail configuration/build for arm-none-eabi toolchain builds.
Code

src/main/target/OMNIBUSF4/CMakeLists.txt[R12-13]

target_stm32f405xg(OMNIBUSF4V3_ICM SKIP_RELEASES)
+target_stm32f405xg(OMNIBUSF4V3_ICM HSE_MHZ 8 SKIP_RELEASES)
Evidence
The target is declared twice in the same CMakeLists. The stm32 build helpers ultimately call
add_executable(${args_NAME}.elf); re-invoking the target macro with the same NAME causes a duplicate
CMake target name and CMake errors.

src/main/target/OMNIBUSF4/CMakeLists.txt[12-13]
cmake/stm32.cmake[358-372]
cmake/stm32.cmake[233-247]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`OMNIBUSF4V3_ICM` is declared twice in `src/main/target/OMNIBUSF4/CMakeLists.txt`. The STM32 CMake helpers create an executable target named `${NAME}.elf`; defining the same NAME twice causes a duplicate target error and breaks configuration/build.

### Issue Context
- `target_stm32()` calls `add_stm32_executable(NAME ${name} ...)`
- `add_stm32_executable()` runs `add_executable(${args_NAME}.elf)`

### Fix Focus Areas
- src/main/target/OMNIBUSF4/CMakeLists.txt[12-13]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

Comment on lines 12 to +13
target_stm32f405xg(OMNIBUSF4V3_ICM SKIP_RELEASES)
target_stm32f405xg(OMNIBUSF4V3_ICM HSE_MHZ 8 SKIP_RELEASES)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Duplicate cmake target 🐞 Bug ✓ Correctness

OMNIBUSF4V3_ICM is defined twice, which will attempt to create the same CMake executable target
(OMNIBUSF4V3_ICM.elf) twice and fail configuration/build for arm-none-eabi toolchain builds.
Agent Prompt
### Issue description
`OMNIBUSF4V3_ICM` is declared twice in `src/main/target/OMNIBUSF4/CMakeLists.txt`. The STM32 CMake helpers create an executable target named `${NAME}.elf`; defining the same NAME twice causes a duplicate target error and breaks configuration/build.

### Issue Context
- `target_stm32()` calls `add_stm32_executable(NAME ${name} ...)`
- `add_stm32_executable()` runs `add_executable(${args_NAME}.elf)`

### Fix Focus Areas
- src/main/target/OMNIBUSF4/CMakeLists.txt[12-13]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant