Add HSE_MHZ option to OMNIBUSF4V3_ICM target#11331
Add HSE_MHZ option to OMNIBUSF4V3_ICM target#11331danilo19992 wants to merge 1 commit intoiNavFlight:masterfrom
Conversation
controladora f4 s3v plus
Branch Targeting SuggestionYou've targeted the
If This is an automated suggestion to help route contributions to the appropriate branch. |
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Review Summary by QodoAdd HSE_MHZ 8 MHz configuration to OMNIBUSF4V3_ICM
WalkthroughsDescription• Adds HSE_MHZ configuration option to OMNIBUSF4V3_ICM target • Sets external oscillator frequency to 8 MHz • Maintains SKIP_RELEASES flag for the target Diagramflowchart LR
A["OMNIBUSF4V3_ICM target"] -- "Add HSE_MHZ 8 MHz" --> B["Enhanced target configuration"]
File Changes1. src/main/target/OMNIBUSF4/CMakeLists.txt
|
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan Code Review by Qodo
1. Duplicate CMake target
|
| target_stm32f405xg(OMNIBUSF4V3_ICM SKIP_RELEASES) | ||
| target_stm32f405xg(OMNIBUSF4V3_ICM HSE_MHZ 8 SKIP_RELEASES) |
There was a problem hiding this comment.
1. Duplicate cmake target 🐞 Bug ✓ Correctness
OMNIBUSF4V3_ICM is defined twice, which will attempt to create the same CMake executable target (OMNIBUSF4V3_ICM.elf) twice and fail configuration/build for arm-none-eabi toolchain builds.
Agent Prompt
### Issue description
`OMNIBUSF4V3_ICM` is declared twice in `src/main/target/OMNIBUSF4/CMakeLists.txt`. The STM32 CMake helpers create an executable target named `${NAME}.elf`; defining the same NAME twice causes a duplicate target error and breaks configuration/build.
### Issue Context
- `target_stm32()` calls `add_stm32_executable(NAME ${name} ...)`
- `add_stm32_executable()` runs `add_executable(${args_NAME}.elf)`
### Fix Focus Areas
- src/main/target/OMNIBUSF4/CMakeLists.txt[12-13]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
controladora f4 s3v plus