Conversation
iamajais
force-pushed
the
feature/distributed-logging
branch
from
75fd801 to
fb97c1a
Compare
…or all grpc services
iamajais
force-pushed
the
feature/distributed-logging
branch
from
fb97c1a to
0f20b78
Compare
| return ServerInterceptors.intercept( | ||
| bindableService, new RequestContextServerInterceptor(), new ThrowableResponseInterceptor()); | ||
| bindableService, | ||
| new RequestContextLoggingServerInterceptor(), |
There was a problem hiding this comment.
Would this log the entire request context which i believe has the jwt too?
Contributor
Author
There was a problem hiding this comment.
it wont log yet. We are just putting key value pairs in MDC context here. logging params will be controlled by log-config.yaml file of individual grpc service. like for scan-manager service we are just logging request-id key
avinashkolluru
approved these changes
Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.