Added new header for routing to desired database#85
Open
KIRTIKUMARKK21 wants to merge 1 commit intohypertrace:mainfrom
Open
Added new header for routing to desired database#85KIRTIKUMARKK21 wants to merge 1 commit intohypertrace:mainfrom
KIRTIKUMARKK21 wants to merge 1 commit intohypertrace:mainfrom
Conversation
|
I caught up with QE as well and for them to be able to test, they would need a way to use both(mongo/pg) for the same tenant. I am thinking should we use two flags on the lines( usePostgres/forceUsePostgres). |
Contributor
aaron-steinfeld
left a comment
There was a problem hiding this comment.
I'd love to hear more about what you're trying to accomplish with this and see if we can find a way to do so that doesn't break abstraction like this. Could we set up some time to discuss (or just ping me)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new
DATABASE_ID_HEADER_KEYconstant (x-database-id) to RequestContextConstants to support database routing decisions in multi-database deployments. This header allows services to specify which database instance should handle a request, enabling database sharding or multi-tenancy at the database level.The header is:
HEADER_PREFIXES_TO_BE_PROPAGATEDto ensure it propagates across gRPC service callsCACHE_MEANINGFUL_HEADERSsince database selection affects query results and must be considered for cache invalidationTesting
Checklist:
Documentation
No documentation changes required - this is an internal constant addition. Services consuming this library will need to document their own usage of the
x-database-idheader based on their specific database routing implementation.