[Bugfix] Fix createOrReplace Behaviour#276
Merged
suddendust merged 1 commit intohypertrace:mainfrom Feb 10, 2026
Merged
Conversation
suddendust
requested review from
avinashkolluru,
kotharironak,
puneet-traceable,
skjindal93 and
suresh-prakash
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
============================================
+ Coverage 80.65% 80.68% +0.03%
Complexity 1396 1396
============================================
Files 240 240
Lines 6871 6882 +11
Branches 638 638
============================================
+ Hits 5542 5553 +11
Misses 914 914
Partials 415 415
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suresh-prakash
approved these changes
Feb 10, 2026
| * | ||
| * <pre>{@code | ||
| * INSERT INTO table (col1, col2, pk_col) | ||
| * INSERT INTO table (col1, col2,, col3, pk_col) |
Contributor
There was a problem hiding this comment.
Nit:
Suggested change
| * INSERT INTO table (col1, col2,, col3, pk_col) | |
| * INSERT INTO table (col1, col2, col3, pk_col) |
suddendust
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in
FlatPostgresCollection#createOrReplacein which for replace cases, it overwrites the unspecified fields with their default values.Testing
Added integration tests to check for this.
Checklist: