Skip to content

fix: exclusive prank/broadcast#56

Open
paco0x wants to merge 1 commit intohuff-language:mainfrom
paco0x:fix/prank-before-broadcast
Open

fix: exclusive prank/broadcast#56
paco0x wants to merge 1 commit intohuff-language:mainfrom
paco0x:fix/prank-before-broadcast

Conversation

@paco0x
Copy link
Copy Markdown

@paco0x paco0x commented Dec 3, 2023

Currently, running HuffDeployer.broadcast("T"); would fail:

   │   ├─ [0] VM::prank(HuffConfig: [0xC7f2Cf4845C6db0e1a1e91ED41Bcd0FcC1b0E141])
    │   │   └─ ← ()
    │   ├─ [0] VM::ffi(["rm", "src/__TEMP__abfzyqnaxzhwmracwudpzrzbuoyhhizhT.huff"])
    │   │   └─ ← 0x
    │   ├─ [0] VM::broadcast()
    │   │   └─ ← you have an active prank; broadcasting and pranks are not compatible
    │   └─ ← you have an active prank; broadcasting and pranks are not compatible
    └─ ← you have an active prank; broadcasting and pranks are not compatible


Error:
script failed: you have an active prank; broadcasting and pranks are not compatible

vm.prank() is not needed when should_broadcast is true.

Copy link
Copy Markdown

@0xClandestine 0xClandestine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants