Potential fix for code scanning alert no. 2: Workflow does not contain permissions#253
Closed
Potential fix for code scanning alert no. 2: Workflow does not contain permissions#253
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Duco Sebel <74970928+DCSBL@users.noreply.github.com>
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Duco Sebel <74970928+DCSBL@users.noreply.github.com>
Signed-off-by: Duco Sebel <74970928+DCSBL@users.noreply.github.com>
Signed-off-by: Duco Sebel <74970928+DCSBL@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/homewizard/api-documentation/security/code-scanning/2
In general, this should be fixed by explicitly declaring a
permissionsblock in the workflow (at the root or per job) so that theGITHUB_TOKENis restricted to the least privileges required. For most build/test/deploy preview jobs, a safe baseline iscontents: read. If the workflow or any actions it uses require additional scopes (e.g., to comment on PRs or update deployment statuses), those specific permissions (likepull-requests: write) should be added explicitly instead of relying on broad defaults.For this specific workflow in
.github/workflows/firebase-hosting-pull-request.yml, the simplest and least intrusive fix is to add a root‑levelpermissionsblock directly under thename:(or underon:) so it applies to all jobs. Starting withcontents: readdocuments that this workflow expects only read access to repository contents. If later it’s discovered thatFirebaseExtended/action-hosting-deploy@v0needs additional scopes, those can be explicitly added, but that’s outside the static analysis finding. No imports or other files need to be changed; the change is a small YAML addition near the top of this file.Concretely:
Edit
.github/workflows/firebase-hosting-pull-request.yml.Insert:
after line 1 (the
name:line), keeping indentation consistent.Leave the rest of the workflow untouched so all existing behavior remains the same, except for the tightened token permissions.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.