Conversation
Member
Author
|
Type errors are coming from 500 on ESM.sh.. |
nvictus
force-pushed
the
push-rvuyomyqtsyt
branch
from
12341a9 to
21ec025
Compare
HiGlass v2.2.2 exports its CSS as `hglib.CSS`, which lets us encapsulate viewer styles using the Constructable Stylesheets API and a Shadow DOM. This prevents HiGlass styles from leaking into (or being affected by) the host notebook environment. The wheel event handler now also calls `preventDefault()` in addition to `stopPropagation()`. With the shadow DOM boundary, `stopPropagation()` alone wasn't sufficient to prevent page scrolling in marimo since composed events cross the shadow boundary.
nvictus
force-pushed
the
push-rvuyomyqtsyt
branch
from
21ec025 to
6172686
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HiGlass v2.2.2 exports its CSS as
hglib.CSS, which lets us encapsulate viewer styles using the Constructable Stylesheets API and a Shadow DOM. This prevents HiGlass styles from leaking into (or being affected by) the host notebook environment.The wheel event handler now also calls
preventDefault()in addition tostopPropagation(). With the shadow DOM boundary,stopPropagation()alone wasn't sufficient to prevent page scrolling in marimo since composed events cross the shadow boundary.higlass-pythonin marimo: