Open
Conversation
manzt
force-pushed
the
push-nslkxxzmuvtk
branch
3 times, most recently
from
edc0ea4 to
b5b55e4
Compare
manzt
added
the
internal
Smoke-tests the HiGlass anywidget render pipeline in headless Chromium via vitest browser mode and Playwright. SwiftShader args are required since PixiJS needs a WebGL context unavailable in headless by default.
manzt
force-pushed
the
push-nslkxxzmuvtk
branch
from
b5b55e4 to
cb0ec3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have a good way of fully e2e testing widget.js, but right now there is not even a simple test that checks if the widget.js module even loads in the browser, leading to a regression in v1.3.4 (#198).
These changes add a smoke test that renders a minimal HiGlass viewer (single
top-axistrack) in headless browser, verifying the module loads andrendercompletes without error.You can run the test locally with
deno task vitest.