-
Notifications
You must be signed in to change notification settings - Fork 12
Add an API to add local data to tracks #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pkerpedjiev
wants to merge
12
commits into
main
Choose a base branch
from
kerpedji/local-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bc3d287
feat: Add an API for adding local data
pkerpedjiev 62f3044
Updated the docs
pkerpedjiev c98bef5
Fix linting error
pkerpedjiev c5ce687
Reverted changes
pkerpedjiev 26d7c91
Formatting fix
pkerpedjiev 862aebd
Bumped higlass version
pkerpedjiev e438d79
Fixed linting errors
pkerpedjiev 02e789e
Fixed formatting
pkerpedjiev a798c5d
Changed to use a tileset rather than track constructor for local tile…
pkerpedjiev 58ed91d
Remove location-listener-
pkerpedjiev 8b8975d
Use preventDefault to stop page scrolling when higlass zooms
pkerpedjiev 6acacf9
Suppress type warning on callbackId
pkerpedjiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of confusing because it isn't really "serving" data at all, it is inlining or embedding the data into the track configs it generates, right?
I like @manzt's suggestion of a name like
InlineTilesetorEmbeddedTileset.(I suppose the same could be said of
local-tilesbeing better named asinline-tilesor similar, but that's outside the scope of this PR).