feat/tests: automatic API coverage checks#93
Merged
Conversation
so it's easier to manage feature flag switches
they could all run together but it's convenient to have 4 different checks on github, easy to see right away
alemidev
previously approved these changes
Mar 9, 2026
Member
alemidev
left a comment
alemidev
left a comment
There was a problem hiding this comment.
With or without requested changes, LGTM and want this merged asap!! :)
this is probably useless once we bump pyo3 but at least we know how to fix it now
alemidev
previously approved these changes
Mar 10, 2026
alemidev
previously approved these changes
Mar 10, 2026
i wish it was easier but apparently we need 2 actions and all this setup to make it work...
alemidev
previously approved these changes
Mar 10, 2026
alemidev
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds mechanism to "automatically" discover the API surface and match the various glues against that surface.
It's not 100% reliable. since it does a direct string matching for calls to the surface. So the idea is that for each method in the API surface a call to that method must happen at least somewhere in the FFI source.
Given that we're trying to have a 1 to 1 mapping in our APIs this seems good enough.
It should support Traits and supertraits as well