Skip to content

[Bugfix] Remote descriptor not found when char handles out of order #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
h2zero merged 1 commit into from
Mar 29, 2026
Merged

[Bugfix] Remote descriptor not found when char handles out of order #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/NimBLERemoteService.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
# include "NimBLELog.h"

# include <climits>
# include <algorithm>

static const char* LOG_TAG = "NimBLERemoteService";

Expand Down Expand Up @@ -207,6 +208,12 @@ bool NimBLERemoteService::retrieveCharacteristics(const NimBLEUUID* uuidFilter)
NimBLEUtils::taskWait(taskData, BLE_NPL_TIME_FOREVER);
rc = taskData.m_flags;
if (rc == 0 || rc == BLE_HS_EDONE) {
// sort the characteristics vector by handle to make sure the search range for descriptors is correct
std::sort(m_vChars.begin(),
m_vChars.end(),
[](const NimBLERemoteCharacteristic* a, const NimBLERemoteCharacteristic* b) {
return a->getHandle() < b->getHandle();
});
NIMBLE_LOGD(LOG_TAG, "<< retrieveCharacteristics()");
return true;
}
Expand Down