Open
Conversation
Adds the WebSocket module to the Node platform allowing Gren programs to create WebSocket servers and handle client connections.
robinheghan
reviewed
Feb 14, 2026
|
|
||
| {-| Convert a [`ConnectionId`](WebSocketServer.ConnectionId) to an `Int`. | ||
|
|
||
| Useful for storing connections in a `Dict Int Connection`. |
Member
There was a problem hiding this comment.
Can't we just expose ConnectionId as Int instead of it being a opaque type? 🤔
Author
There was a problem hiding this comment.
We could, it's mostly a stylistic choice. I didn't want to leak implementation details especially since the Connection isn't directly implemented in Gren. I'm ok changing it if you have a strong opinion.
Author
|
I pushed a new commit addressing your comments. I also noticed that I forgot to update the integration script runner and that all the integration tests were on 0.6.2 so I updated those to 0.6.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds WebSocket server capabilities.
This is mostly modeled after the HttpServer module. There are tests but I haven't integrated it into a real application yet (going to work on gren-lang/browser#101 next so I have both parts to test with).