add a low-data-mode option to disable images#438
Open
sratabix wants to merge 1 commit intogotify:masterfrom
Open
add a low-data-mode option to disable images#438sratabix wants to merge 1 commit intogotify:masterfrom
sratabix wants to merge 1 commit intogotify:masterfrom
Conversation
jmattheis
reviewed
Feb 13, 2026
| error(R.drawable.ic_alarm) | ||
| placeholder(R.drawable.ic_placeholder) | ||
| if (lowDataMode) { | ||
| holder.image.visibility = View.GONE |
Member
There was a problem hiding this comment.
Have you considered setting https://coil-kt.github.io/coil/api/coil-core/coil3.request/-options/network-cache-policy.html to CachePolicy.Disabled in com.github.gotify.CoilInstance#makeImageLoader? This should display already cache images, but doesn't request images that aren't cached.
This would remove the need to implement the lowDataMode for every image loading done in the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This option disables the loading of images from the server