fix(storage): skip downloading blobs whose name contain ":" eg: C: D: etc when application runs in Windows.

[chandra-siri]

skip downloading blobs whose name contain ":" eg: C: D: etc when application runs in Windows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of path handling within the storage client, specifically addressing an edge case with Windows full paths containing colons. It introduces a dedicated InvalidPathError and modifies the download process to gracefully handle such malformed paths by skipping the problematic download and issuing a user warning, thereby improving the overall user experience and preventing unexpected failures.

Highlights

• New Exception Type: Introduced InvalidPathError to specifically handle cases where a provided path string is malformed.
• Windows Path Validation: Modified the _resolve_path function to detect and raise InvalidPathError when a Windows-style path containing a colon (e.g., "C:\file.txt") is encountered, preventing its use in downloads.
• Graceful Error Handling: Updated download_many_to_path to catch InvalidPathError during path resolution, issue a UserWarning for the problematic blob, and continue processing other blobs instead of failing the entire operation.
• Unit Tests: Added new unit tests to verify that _resolve_path correctly raises InvalidPathError on Windows for invalid paths and that download_many_to_path properly handles this exception by issuing a warning.

Changelog

• google/cloud/storage/exceptions.py
  • Added a new exception class, InvalidPathError, for malformed path strings.
• google/cloud/storage/transfer_manager.py
  • Imported the new InvalidPathError.
  • Modified _resolve_path to raise InvalidPathError if a Windows path contains a colon.
  • Implemented a try-except block in download_many_to_path to catch InvalidPathError, issue a UserWarning, and skip the problematic blob.
  • Removed an extra blank line.
• tests/unit/test_transfer_manager.py
  • Added test__resolve_path_raises_invalid_path_error_on_windows to verify the new path validation logic.
  • Added test_download_many_to_path_raises_invalid_path_error to confirm that download_many_to_path correctly handles InvalidPathError with a warning.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an InvalidPathError exception to handle Windows paths with colons in the transfer_manager.py file. The _resolve_path function now raises this exception when encountering such paths on Windows, and the download_many_to_path function catches this exception, issues a warning, and skips the download. Unit tests have been added to verify the new functionality. The review comments suggest further opportunities to improve code readability, error messaging, and test robustness.

[gemini-code-assist]

The assertion message cannot be downloaded into is too specific and duplicates the implementation detail. It would be better to assert a more general message indicating that the path is invalid, which is less prone to break if the implementation changes.

        with pytest.raises(InvalidPathError) as exc_info:
            _resolve_path("C:\\target", "C:\\target\\file.txt")
        assert "Invalid path" in str(exc_info.value)

[chandra-siri]

/gcbrun(948de5f)