fix: honor RetryInfo.retryDelay for 429 RESOURCE_EXHAUSTED#2114
Open
hermann-o wants to merge 1 commit intogoogleapis:mainfrom
Open
fix: honor RetryInfo.retryDelay for 429 RESOURCE_EXHAUSTED#2114hermann-o wants to merge 1 commit intogoogleapis:mainfrom
hermann-o wants to merge 1 commit intogoogleapis:mainfrom
Conversation
hermann-o
force-pushed
the
fix/retry-delay-issue-1875
branch
2 times, most recently
from
795a647 to
3c77703
Compare
hermann-o
changed the title
|
Hi @hermann-o, Thanks for reaching out us! Looks like branch is out of date, Kindly please update the branch. Thanks |
hermann-o
force-pushed
the
fix/retry-delay-issue-1875
branch
from
3c77703 to
3db3ff9
Compare
Author
updated |
hermann-o
force-pushed
the
fix/retry-delay-issue-1875
branch
from
3db3ff9 to
1eb0dbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and test for issue: #1875
Adding code to extract retryDelay from error details in case:
code == 429
status == "RESOURCE_EXHAUSTED"
and wait as suggested.
In fact we wait 1 sec longer as indicated by google.rpc.RetryInfo, given this sample
[429 RESOURCE_EXHAUSTED. {'error': {'code': 429, 'message': 'You exceeded [...] Please retry in 58.934310785s.', 'status': 'RESOURCE_EXHAUSTED', 'details': [...] '@type': 'type.googleapis.com/google.rpc.RetryInfo', 'retryDelay': '58s'}]}}.)