Skip to content

chore: add ruff to librarian container#15561

Closed
ohmayr wants to merge 1 commit intomainfrom
update-generator-requirements-to-include-ruff
Closed

chore: add ruff to librarian container#15561
ohmayr wants to merge 1 commit intomainfrom
update-generator-requirements-to-include-ruff

Conversation

@ohmayr
Copy link
Contributor

@ohmayr ohmayr commented Feb 11, 2026

add ruff to librarian container

@ohmayr ohmayr requested review from a team as code owners February 11, 2026 18:15
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the ruff linter into the project's development environment by adding it to the primary and test dependency files. This enhancement aims to improve code quality, consistency, and maintainability by leveraging ruff's fast and comprehensive linting capabilities.

Highlights

  • Dependency Addition: The ruff linter, version 0.14.14, has been added to both the development and test dependency lists.
Changelog
  • .generator/requirements-test.in
    • Added ruff==0.14.14 to the list of test dependencies.
  • .generator/requirements.in
    • Added ruff==0.14.14 to the list of development dependencies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds ruff to the generator's requirements. However, the specified version for ruff (0.14.14) appears to be invalid and will cause dependency installation to fail. I've suggested removing the version pin to let pip-compile handle it. Additionally, both modified requirements files are missing a final newline character, which is a recommended practice.

build
black==23.7.0
isort==5.11.0
ruff==0.14.14 No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified version 0.14.14 for ruff appears to be invalid, as ruff does not follow this versioning scheme. This will likely cause dependency installation to fail. It's recommended to remove the version pin to allow pip-compile to resolve the correct version. Additionally, it's a good practice for text files to end with a newline character, which is missing here.

ruff

build
black==23.7.0
isort==5.11.0
ruff==0.14.14 No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The specified version 0.14.14 for ruff appears to be invalid, as ruff does not follow this versioning scheme. This will likely cause dependency installation to fail. It's recommended to remove the version pin to allow pip-compile to resolve the correct version. Additionally, it's a good practice for text files to end with a newline character, which is missing here.

ruff

@parthea
Copy link
Contributor

parthea commented Feb 11, 2026

Prefer #15536

@parthea parthea closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants