Conversation
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds ruff to the generator's requirements. However, the specified version for ruff (0.14.14) appears to be invalid and will cause dependency installation to fail. I've suggested removing the version pin to let pip-compile handle it. Additionally, both modified requirements files are missing a final newline character, which is a recommended practice.
| build | ||
| black==23.7.0 | ||
| isort==5.11.0 | ||
| ruff==0.14.14 No newline at end of file |
There was a problem hiding this comment.
The specified version 0.14.14 for ruff appears to be invalid, as ruff does not follow this versioning scheme. This will likely cause dependency installation to fail. It's recommended to remove the version pin to allow pip-compile to resolve the correct version. Additionally, it's a good practice for text files to end with a newline character, which is missing here.
ruff
| build | ||
| black==23.7.0 | ||
| isort==5.11.0 | ||
| ruff==0.14.14 No newline at end of file |
There was a problem hiding this comment.
The specified version 0.14.14 for ruff appears to be invalid, as ruff does not follow this versioning scheme. This will likely cause dependency installation to fail. It's recommended to remove the version pin to allow pip-compile to resolve the correct version. Additionally, it's a good practice for text files to end with a newline character, which is missing here.
ruff
|
Prefer #15536 |
add ruff to librarian container