Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Feb 9, 2026

See #11000.

This PR should be merged with a merge-commit, not a squash-commit, in order to preserve the git history.

crwilcox and others added 30 commits March 20, 2019 13:41
* Remove classifier for Python 3.4 for end-of-life.

* Update supported versions in Client README, Contributing Guide
* Add 'user_agent' and 'extra_headers' properties to 'Connection'.

   Deprecate the 'USER_AGENT' and '_EXTRA_HEADERS' class-level attributes.

* Add 'client_info' parameter to 'Connection' ctor.

* Implement 'Connection.user_agent' via its '_client_info'.

* Ensure 'X-Goog-API-Client' header is always passed.

* Create/use non-GAPIC-specific 'ClientInfo' class FBO HTTP/JSON clients.

  Derive the existing GAPIC class from it.
Needed for new 'client_info' support.
…t.o. (#8207)

* Prevent requests from hanging on SSL handshake issue by adding a max timeout of 5 minutes

* rename and reuse constant

* use named arg
* chore(core): release 1.1.0

* Add minor markup improvent to CHANGELOG

Co-Authored-By: Tim Swast <swast@google.com>
* chore: add split repo templates

* test: install api core from package manager
gurusai-voleti and others added 4 commits February 9, 2026 12:00
Automated: Migrate {target_path} from gsutil to gcloud storage

This CL is part of the on going effort to migrate from the legacy
`gsutil` tool to the new and improved `gcloud storage` command-line
interface.
`gcloud storage` is the recommended and modern tool for interacting with
Google Cloud Storage, offering better performance, unified
authentication, and a more consistent command structure with other
`gcloud` components. 🚀

### Automation Details

This change was **generated automatically** by an agent that targets
users of `gsutil`.
The transformations applied are based on the [gsutil to gcloud storage
migration guide](http://go/gsutil-gcloud-storage-migration-guide).

### ⚠️ Action Required: Please Review and Test Carefully

While we have based the automation on the migration guide, every use
case is unique.
**It is crucial that you thoroughly test these changes in environments
appropriate to your use-case before merging.**
Be aware of potential differences between `gsutil` and `gcloud storage`
that could impact your workflows.
For instance, the structure of command output may have changed,
requiring updates to any scripts that parse it. Similarly, command
behavior can differ subtly; the `gcloud storage rsync` command has a
different file deletion logic than `gsutil rsync`, which could lead to
unintended file deletions.

Our migration guides can help guide you through a list of mappings and
some notable differences between the two tools.

Standard presubmit tests are run as part of this CL's workflow. **If you
need to target an additional test workflow or require assistance with
testing, please let us know.**

Please verify that all your Cloud Storage operations continue to work as
expected to avoid any potential disruptions in production.

### Support and Collaboration

The `GCS CLI` team is here to help! If you encounter any issues, have a
complex use case that this automated change doesn't cover, or face any
other blockers, please don't hesitate to reach out.
We are happy to work with you to test and adjust these changes as
needed.

**Contact:** `gcs-cli-hyd@google.com`

We appreciate your partnership in this important migration effort!

#gsutil-migration
…n' into migration.python-cloud-core.migration.2026-02-09_17-15-38.migrate
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes a significant architectural change by migrating the google-cloud-core Python library into a dedicated packages/google-cloud-core directory. This move centralizes the library's components, including its core logic, testing infrastructure, and comprehensive documentation, under a new, standardized package structure. The migration ensures that the library's full development history is maintained, and the underlying migration tooling has been improved to handle complex repository structures like those involving submodules, thereby enhancing the overall integrity and future maintainability of the codebase.

Highlights

  • Codebase Migration: The entire google-cloud-core library, including its source code, documentation, and configuration files, has been migrated into a new packages/google-cloud-core subdirectory within the repository.
  • Configuration and Tooling Setup: New configuration files for development tools such as .coveragerc, .flake8, mypy.ini, noxfile.py, pytest.ini, and setup.py have been added to establish proper linting, testing, and build processes for the newly structured package.
  • Git History Preservation: The pull request explicitly requests a merge-commit to ensure that the complete git history of the google-cloud-core library is preserved during this migration, which is critical for maintaining an accurate record of changes.
  • Migration Script Enhancements: The single-library.git-migrate-history.sh script, used for the migration, was updated to include --recurse-submodules during cloning and to remove .git directories from submodules within the tree-filter step, making the migration process more robust for repositories with submodules.
Changelog
  • packages/google-cloud-core/.coveragerc
    • Added a new coverage configuration file, specifying branch coverage, omission patterns for temporary files and __init__.py files, and exclusion rules for NO COVER pragmas, __repr__ methods, and NotImplementedError.
  • packages/google-cloud-core/.flake8
    • Introduced a flake8 configuration file to enforce code style, including Google-style import order and ignoring specific linting errors like E203, E266, E501, W503, and I202.
  • packages/google-cloud-core/CHANGELOG.md
    • The complete historical changelog for google-cloud-core has been added, detailing releases from version 2.5.0 down to 0.28.0, encompassing features, bug fixes, documentation updates, and breaking changes.
  • packages/google-cloud-core/google/cloud/_helpers/init.py
    • Added the core helper utilities module, which includes functions for datetime conversions, protobuf handling, and gRPC channel/stub creation, along with internal helper classes like _LocalStack.
  • packages/google-cloud-core/scripts/split_repo_migration/single-library.git-migrate-history.sh
    • Modified the migration script to use git clone --recurse-submodules and to incorporate git submodule update --init --recursive; find . -mindepth 2 -name .git -exec rm -rf {} +; within the tree-filter to correctly handle and clean up submodules during the history migration process.
Activity
  • No human activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates the python-cloud-core library into this repository. The changes are extensive, involving the addition of the library's source code, tests, documentation, and various configuration files for CI/CD and development tooling. My review focused on the overall structure and correctness of the newly added files. The migration appears to be well-executed. I've added a couple of suggestions for minor improvements regarding mypy configuration and a security best practice in a utility script.

@parthea parthea self-assigned this Feb 11, 2026
@parthea parthea marked this pull request as ready for review February 12, 2026 22:33
@parthea parthea requested review from a team as code owners February 12, 2026 22:33
@parthea parthea assigned daniel-sanche and unassigned parthea Feb 12, 2026
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 12, 2026
@parthea
Copy link
Contributor Author

parthea commented Feb 12, 2026

Code is ready for review but not merge

@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 13, 2026
@parthea parthea merged commit 540025b into main Feb 13, 2026
28 checks passed
@parthea parthea deleted the migration.python-cloud-core.migration.2026-02-09_17-15-38.migrate branch February 13, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.