Fix LoRA merge for sharded Gemma 3 checkpoints and HF parameter mapping#1336
Open
ayehninnkhine wants to merge 2 commits intogoogle:mainfrom
Open
Fix LoRA merge for sharded Gemma 3 checkpoints and HF parameter mapping#1336ayehninnkhine wants to merge 2 commits intogoogle:mainfrom
ayehninnkhine wants to merge 2 commits intogoogle:mainfrom
Conversation
Added load_base_state function to handle loading of model states from single or sharded safetensors files. Updated save_lora_merged_model_as_safetensors to use the new load_base_state function.
ayehninnkhine
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
s-noghabi,
sizhit2,
tianshub and
wang2yn84
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes LoRA merge failures with Hugging Face Gemma 3 checkpoints.
Changes
Current implementation assumes:
This causes errors when using modern HF models (e.g., Gemma 3 4B). This PR ensures compatibility.