[tunix/sft] Add shard_input_data flag to PeftTrainer#1325
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
[tunix/sft] Add shard_input_data flag to PeftTrainer#1325copybara-service[bot] wants to merge 1 commit intomainfrom
shard_input_data flag to PeftTrainer#1325copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
Adds the `shard_input_data` boolean flag to `TrainingConfig` (defaulting to True) to control whether inputs should be automatically sharded within the training and evaluation loops. This provides flexibility for users to disable auto-sharding in cases where the input data is already appropriately sharded before being passed to the trainer (e.g. via an external data loader). Also adds `test_shard_input_data_flag` to `peft_trainer_test.py` to verify that `sharding_utils.shard_input` is called only when the flag is set to True. PiperOrigin-RevId: 891043878
copybara-service
bot
requested review from
abheesht17,
hgao327,
jiangyangmu,
lc5211,
sizhit2,
tianshub and
wang2yn84
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tunix/sft] Add
shard_input_dataflag to PeftTrainerAdds the
shard_input_databoolean flag toTrainingConfig(defaulting to True) to control whether inputs should be automatically sharded within the training and evaluation loops.This provides flexibility for users to disable auto-sharding in cases where the input data is already appropriately sharded before being passed to the trainer (e.g. via an external data loader).
Also adds
test_shard_input_data_flagtopeft_trainer_test.pyto verify thatsharding_utils.shard_inputis called only when the flag is set to True.