Do not increase pointer after last enum constant#2670
Open
zbynek wants to merge 1 commit intogoogle:masterfrom
Open
Do not increase pointer after last enum constant#2670zbynek wants to merge 1 commit intogoogle:masterfrom
zbynek wants to merge 1 commit intogoogle:masterfrom
Conversation
zbynek
force-pushed
the
enum-ptr-skip
branch
from
6e0ef0a to
9354546
Compare
zbynek
force-pushed
the
enum-ptr-skip
branch
from
9354546 to
9cc9214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last occurence of
ptr += objSizein enum declaration is redundant and produces warnings withxcodebuild ... analyze.This PR makes sure this extra assignment is skipped.