Emit OK HTTP status in import callback instead of handler

[rfontanarosa]

closes #1920

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the way HTTP OK status codes are handled in the import callback mechanism. By moving the explicit emission of the 200 OK status from the generic handler to the specific importGeoJsonCallback, the change ensures that successful GeoJSON import operations consistently return the correct HTTP status, improving API reliability and clarity for clients.

Highlights

• HTTP Status Code Handling: The OK (200) HTTP status code is now explicitly emitted within the importGeoJsonCallback function, ensuring that successful API calls consistently return the expected status. Previously, this was handled implicitly or inconsistently by the invokeCallbackAsync handler.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• functions/src/handlers.ts
  • Removed the explicit res.status(StatusCodes.OK).end() call from the success callback within invokeCallbackAsync.
  • Reordered imports for Request and onRequest.
• functions/src/import-geojson.ts
  • Added res.status(StatusCodes.OK) to explicitly set the status code before sending the response in importGeoJsonCallback.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly moves the responsibility of sending the HTTP OK status from the generic handler to the specific import callback. This is a good architectural improvement. I've added one suggestion to use res.json() for sending JSON responses, which is more idiomatic and ensures the Content-Type header is set correctly.