Use canCollectData for LOI write permission

[rfontanarosa]

closes #1887

now the rules check if (user is owner AND canCollect data) OR canManageSurvey.

so, removed users who are not in the ACL can't modify the data.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the security posture of the application by refining the Firestore security rules. The primary goal is to ensure that data modification operations for LOIs and Submissions are restricted to users who not only own the data but also have explicit permission to collect data within the survey context. This change prevents unauthorized data manipulation by users who might have previously held ownership but lack current data collection privileges.

Highlights

• Security Rules Enhancement: Updated Firestore security rules for Location of Interest (LOI) and Submission documents to enforce stricter write permissions. Users who own an LOI or Submission can now only update or delete it if they also possess the canCollectData permission for the associated survey. Previously, ownership alone was sufficient.
• Access Control Refinement: Implemented a change that prevents users not explicitly in the Access Control List (ACL) from modifying data, even if they were previously considered an owner. This ensures that only authorized users with data collection privileges can perform write operations.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enhances the Firestore security rules for updating and deleting LOIs and submissions. The new rule requires a user to either be a survey manager, or be the owner of the item and have data collection permissions. This change correctly prevents users who have been removed from a survey's ACL from modifying their old data. The implementation is correct and consistently applied.