Skip to content

Various logging clean-up / upgrades#112

Merged
aruby-blackberry merged 2 commits intogoogle:mainfrom
aruby-blackberry:upgrade-logging
Mar 19, 2026
Merged

Various logging clean-up / upgrades#112
aruby-blackberry merged 2 commits intogoogle:mainfrom
aruby-blackberry:upgrade-logging

Conversation

@aruby-blackberry
Copy link
Collaborator

See commits for desciption.

At default logging level, can now see the ExternalMemoryMode logged at INFO:

...
 [vk_common_operations.cpp(1289)] Selecting Vulkan device: V3D 7.1.7.0, Version: 1.3.311
 [vk_common_operations.cpp(1293)] Using Vulkan externalMemoryMode: QnxScreenBuffer for VkEmulation
 [vk_common_operations.cpp(260)] Warning: using non-cached HOST_VISIBLE type for staging memory
 [vk_common_operations.cpp(1586)] Initializing VkEmulation features:
[vk_common_operations.cpp(1587)]     glInteropSupported: false
 [vk_common_operations.cpp(1589)]     useDeferredCommands: true
...

@aruby-blackberry aruby-blackberry requested review from gurchetansingh, jmacnak and kocdemir and removed request for kocdemir March 18, 2026 22:17
@aruby-blackberry
Copy link
Collaborator Author

@jmacnak please merge.

@jmacnak
Copy link
Member

jmacnak commented Mar 19, 2026

@aruby-blackberry : @gurchetansingh might have found the magic config option to allow collaborators to kick off kokoro as well. If you can, perhaps try force pushing your branch in like an hour or so and we'll see if it kicks off automatically

@aruby-blackberry
Copy link
Collaborator Author

@aruby-blackberry : @gurchetansingh might have found the magic config option to allow collaborators to kick off kokoro as well. If you can, perhaps try force pushing your branch in like an hour or so and we'll see if it kicks off automatically

Ahh, thanks for doing some searching! I will try that in about an hour then 👍

@gurchetansingh
Copy link
Collaborator

You can also check the right side and try adding "kokoro run" label as well.

@gurchetansingh
Copy link
Collaborator

@jmacnak hmm looks like the @GoogleGfxstreamTesterBot is removing kokoro-run labels.

@aruby-blackberry
Copy link
Collaborator Author

@jmacnak hmm looks like the @GoogleGfxstreamTesterBot is removing kokoro-run labels.

@gurchetansingh actually I think this fine; the kokoro run has now started, so that's good!

@jmacnak
Copy link
Member

jmacnak commented Mar 19, 2026

Yeah, it removes the label once it starts running.

@aruby-blackberry aruby-blackberry added this pull request to the merge queue Mar 19, 2026
Merged via the queue into google:main with commit 680ada8 Mar 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants