Swarming: Implement JSON env var encapsulation and v2 API protos#5170
Open
Swarming: Implement JSON env var encapsulation and v2 API protos#5170
Conversation
jardondiego
reviewed
Feb 25, 2026
Collaborator
|
I think it's important to be more specific with both the title and description. |
jardondiego
reviewed
Feb 25, 2026
| @@ -0,0 +1,18 @@ | |||
| # Copyright 2023 Google LLC | |||
Collaborator
There was a problem hiding this comment.
Sorry I am not sure if these gRPC should be on this PR. Are they needed for changes in swarming/__init__.py?
Collaborator
Author
There was a problem hiding this comment.
All of the used protos in this repo live under src/_internal/protos, i just added the ones that were missing but maybe @letitz can give more context here
IvanBM18
changed the title
Collaborator
Author
Yeah i guess it was a little bit to generic, thanks for the feedback |
jardondiego
reviewed
Feb 25, 2026
| return new_task_request | ||
|
|
||
|
|
||
| def _compress_env_vars( |
Collaborator
There was a problem hiding this comment.
nit: We could also name it _env_vars_to_json to be more clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the last details in the base of clusterfuzz-swarming integration.
This PR finalizes the base integration for Clusterfuzz-Swarming. The primary focus is ensuring environment variable persistence across Docker/ swarming bots and laying the groundwork for the Swarming v2 API.
This integration will later be refactored to use remote_tasks once the remote task gate allows to send tasks to specific backends always that some conditions are given.
Bug: b/479476219