Open
Conversation
The idea is if we schedule a bunch of NOOP jobs and we don't see many in the last hour, that things are congested. This might not react fast enough to congestion, but can potentially pause things for long enough to drain the queue. In the future we should stop hardcoding and infer how many we should see completed in the last hour. Other future improvements can be testing congestion by subconfig so we can tell if some other resource is saturated.
Collaborator
Author
|
/gcbrun |
Collaborator
Author
|
Done. PTAL again |
Collaborator
Author
|
Actually it's not reay yet. Still dealing with the merge conflict |
|
This pull request has not had any activity for 60 days and will be automatically closed in two weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is if we schedule a bunch of NOOP jobs and we don't see
many in the last hour, that things are congested.
This might not react fast enough to congestion, but can potentially
pause things for long enough to drain the queue.
In the future we should stop hardcoding and infer how many we should
see completed in the last hour.
Other future improvements can be testing congestion by subconfig
so we can tell if some other resource is saturated.