Rust: Distinguish path resolution expectations from type inference expectations #21282
+55
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * for non-methods. | ||
| */ | ||
| pragma[nomagic] | ||
| Type getAssocFunctionTypeInclNonMethodSelfAt( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/path-resolution/type-inference-expectations
branch
from
4bd25e7 to
becd002
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Rust path-resolution inline expectations tests to distinguish between symbols resolved via path resolution vs those that require type inference, making test expectations more explicit and interpretable.
Changes:
- Introduce
targetexpectations for call targets only resolvable with type inference. - Introduce
item_no_targetexpectations for items only resolvable via path resolution (and not matching the inferred call target). - Update the path-resolution inline expectations test harness to recognize and emit these additional tags.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/library-tests/path-resolution/my.rs | Updates an inline expectation to use target=to_string to reflect type-inference-only call targeting. |
| rust/ql/test/library-tests/path-resolution/main.rs | Re-labels several call-site expectations from item to target / item_no_target to reflect the new distinction. |
| rust/ql/lib/utils/test/PathResolutionInlineExpectationsTest.qll | Extends the inline expectations harness to support target and item_no_target tags in addition to item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
itemtags withtargettags when a call target can only be resolved with type inference, and replacesitemtags withitem_no_targettags when a call target can only be resolved with path resolution.This makes it clear when type inference improves upon targets resolved in path resolution.