Open
Conversation
This enables users to only trigger to specific resources. For more info see: https://docs.sigstore.dev/policy-controller/overview/#policies-matching-specific-resource-types-and-labels
Author
|
There is some auto formatting stuff done in the value file, if you think that is an issue I can revert it |
There was a problem hiding this comment.
Pull request overview
This PR adds support for the match field in ClusterImagePolicy resources, enabling users to specify additional matching criteria to target specific Kubernetes resource types and labels. This enhancement allows for more granular control over which resources the image verification policy applies to, as documented in the Sigstore policy-controller documentation.
Key changes:
- Added
matchfield configuration to values.yaml with commented examples showing how to match specific resources like jobs and pods - Updated the github-policy template to conditionally include the match field when configured
- Standardized quote style from single to double quotes for string values in values.yaml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/trust-policies/values.yaml | Adds match field configuration with commented examples for resource matching; standardizes string quotes to double quotes |
| charts/trust-policies/templates/clusterimagepolicy-github.yaml | Adds conditional template logic to include the match field in the ClusterImagePolicy spec when configured |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables users to only trigger to specific resources. For more info see: https://docs.sigstore.dev/policy-controller/overview/#policies-matching-specific-resource-types-and-labels
You could argue that we should add the same for github-exempt-policy, but since it exempt, it's probably easier to just skip it.