Conversation
| 'peerId': peerId, | ||
| 'orgName': orgName, | ||
| }); | ||
| var response = await http.post( |
There was a problem hiding this comment.
we might need a try catch
There was a problem hiding this comment.
Ok will do that.
There was a problem hiding this comment.
http post can fail too, we need catch for that case
| } | ||
|
|
||
| class OrgAccessToken { | ||
| static final int _accessTokenMaxAge = 30; // days |
There was a problem hiding this comment.
token age might be something we have to worry about but not during a poc. We need to come back on this.
| return Response.ok('Transaction request received'); | ||
| } | ||
|
|
||
| Future<bool> externalApi({required String did,required String peerId,required String orgName,required String callBackUrl,required Token orgAccessToken })async { |
There was a problem hiding this comment.
This function should be named fireAuthCallback or something similar. It
doesn't need orgName
did and peerId need not be separate
There was a problem hiding this comment.
Ok will make these changes and put a new commit.
|
Also generate protos again to fix the conflicts, I had merged a pending PR to avoid confusion |
|
|
||
| Future<bool> externalApi({required String did,required String peerId,required String orgName,required String callBackUrl,required Token orgAccessToken })async { | ||
| var bodyJsonStr = jsonEncode({ | ||
| 'did': did, |
| Uri.http(callBackUrl), | ||
| headers: <String, String>{ | ||
| 'Content-Type': 'application/json; charset=UTF-8', | ||
| 'Authorization': 'Bearer $orgAccessToken', |
There was a problem hiding this comment.
token should move to body. We are giving a token for them to access our apis
| Future<bool> externalApi({required String did,required String peerId,required String orgName,required String callBackUrl,required Token orgAccessToken })async { | ||
| var bodyJsonStr = jsonEncode({ | ||
| 'did': did, | ||
| 'peerId': peerId, |
There was a problem hiding this comment.
add chain too. also add chain in access token
| return Response.ok('Transaction request received'); | ||
| } | ||
|
|
||
| Future<bool> externalApi({required String did,required String peerId,required String orgName,required String callBackUrl,required Token orgAccessToken })async { |
There was a problem hiding this comment.
at the last, this function shall move to another file as it is generic. Shall create a new module, - sky_outgoing_calls
Allen-Cherian
force-pushed
the
feat/externalorgaccess
branch
from
a68e34c to
f56cb65
Compare
| return false; | ||
| } | ||
| }catch(e){ | ||
| print(e); |
There was a problem hiding this comment.
print stack trace too
Allen-Cherian
force-pushed
the
feat/externalorgaccess
branch
from
85a87f0 to
03a49ac
Compare
Allen-Cherian
force-pushed
the
feat/externalorgaccess
branch
from
03a49ac to
dbdf580
Compare
| }); | ||
| try{ | ||
| var response = await http.post( | ||
| Uri.http(callBackUrl), |
| var bodyJsonStr = jsonEncode({ | ||
| 'did': '$did.$peerId', | ||
| 'session_id': sessionId, | ||
| 'token': orgAccessToken, |
There was a problem hiding this comment.
orgAccessToken is of Token class, we just need the token value inside it which is a string, that is what we can pass through an api.
| Future<OrgStatus> approveOrgAuthRequest( | ||
| ServiceCall call, OrgAuthRequest request) async { | ||
| var user = RubixService.getAuthUser(call); | ||
| const rubix = 'rubix'; |
There was a problem hiding this comment.
this must have been coming from phone,
There was a problem hiding this comment.
no, no, not need as this is rubix ext rpc. But could have simply passed this to the next function without having to store it in a variable.
There was a problem hiding this comment.
Ok will make that change.
Allen-Cherian
force-pushed
the
feat/externalorgaccess
branch
from
38c1334 to
350c94f
Compare
2 participants
No description provided.